Use constructor property promotion in module Ui

[leonhelmus]

Description (*)

Replace allmost all properties with constructor property promotion in module Ui: https://stitcher.io/blog/constructor-promotion-in-php-8

• Readable code
• Make Magento less complex by removing properties which take up a lot of lines.
• Imported all classes to make code more readable.

I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now :).

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @leonhelmus. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[leonhelmus]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[leonhelmus]

@ihor-sviziev I get a lot of warnings in test Semantic Version Checker that it's a major patch, but the protected property still exists except now it's a constructor property promotion. Do you know what im doing wrong? I ask you since you ran my last test in #37026

[ihor-sviziev]

I think svc check isn’t supporting the constructor property promotions yet

…

On Wed, 8 Mar 2023 at 20:17 leonhelmus ***@***.***> wrote: @ihor-sviziev <https://github.com/ihor-sviziev> I get a lot of warnings in test Semantic Version Checker that it's a major patch, but the protected property still exists except now it's a constructor property promotion. Do you know what im doing wrong? I ask you since you ran my last test in #37026 <#37026> — Reply to this email directly, view it on GitHub <#37032 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOJOUIAFRKDN2LB4KCS7UTW3DEMTANCNFSM6AAAAAAVTUQJQ4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[leonhelmus]

@ihor-sviziev ah alright, so for now I can ignore it?

BTW if you have any advice for me on how to get these merged please let me know. I'm currently on 20 + modules so I'm going through all of them. I think this could reduce the amount of lines by a LOT. So its a nice way to make Magento more readable/smaller.

It would be nice if we could add this check in coding standards Magento. Or is that to soon?

Last question hehe, how do i add the label described here:
https://developer.adobe.com/commerce/contributor/guides/code-contributions/#partners

Im working for the company Youwe. So i want to add the labels "partners-contribution" & "Partner: Youwe". How to add this i cannot seem to do it myself and i'm not sure where to request this?