[MFTF] AdminClickCreateOrderOnEditCustomerPageActionGroup adding #34260

AnnaAPak · 2021-10-06T13:41:23Z

Tests have been updated with AdminClickCreateOrderOnEditCustomerPageActionGroup

Related Pull Requests

(!) Please, note: the test is dependent on #34249 changes

m2-assistant · 2021-10-06T13:41:27Z

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AnnaAPak · 2021-10-06T13:47:37Z

@magento run Semantic Version Checker, Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-10-06T13:47:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…erPageActionGroup

sidolov · 2021-10-14T19:02:04Z

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

magento-automated-testing · 2021-10-14T19:02:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-10-15T17:31:14Z

@magento run Functional Tests CE,Functional Tests B2B

magento-automated-testing · 2021-10-15T17:31:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-10-18T17:49:19Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-10-18T17:49:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-10-22T07:15:35Z

Hi @edenduong, thank you for the review.
ENGCOM-9274 has been created to process this Pull Request
✳️ @edenduong, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

magento-automated-testing · 2021-10-22T15:12:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov

@AnnaAPak please, resolve merge conflicts

engcom-Charlie · 2022-02-16T08:57:31Z

As per this comment since the related PR is merged to 2.4-develop so moving this PR back to Changes Requested column.

Thank you!

engcom-Charlie · 2022-02-21T11:06:44Z

@magento run all tests

magento-automated-testing · 2022-02-21T11:06:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-02-21T13:02:46Z

@magento run Semantic Version Checker

magento-automated-testing · 2022-02-21T13:02:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-02-21T13:57:44Z

@magento run Semantic Version Checker

magento-automated-testing · 2022-02-21T13:57:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…ckCreateOrderOnEditCustomerPageActionGroup

engcom-Charlie · 2022-02-22T05:19:41Z

@magento run all tests

magento-automated-testing · 2022-02-22T05:19:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-02-22T08:52:17Z

@magento run Semantic Version Checker, Functional Tests CE

magento-automated-testing · 2022-02-22T08:52:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-02-22T12:59:42Z

@magento run Semantic Version Checker, Functional Tests CE

magento-automated-testing · 2022-02-22T12:59:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-02-23T06:15:17Z

@magento run Semantic Version Checker

magento-automated-testing · 2022-02-23T06:15:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…ckCreateOrderOnEditCustomerPageActionGroup

engcom-Charlie · 2022-02-24T05:43:57Z

@magento run all tests

magento-automated-testing · 2022-02-24T05:44:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-02-28T10:10:11Z

@magento run all tests

magento-automated-testing · 2022-02-28T10:10:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-03-09T11:50:56Z

Hi @AnnaAPak,

The refactoring of 'click selector="{{AdminCustomerMainActionsSection.createOrderBtn}}" stepKey="clickCreateOrder"/>' by using any action group is already done on magento 2.4 with the help of “AdminClickCreateOrderButtonOnEditCustomerPageActionGroup” action group.

Since the intent of this PR is already been taken care in magento 2.4, hence closing this PR.

Please reopen and update if you wish to continue.

Thank you for your contribution!

engcom-Charlie · 2022-03-09T11:50:56Z

Hi @AnnaAPak,

The refactoring of 'click selector="{{AdminCustomerMainActionsSection.createOrderBtn}}" stepKey="clickCreateOrder"/>' by using any action group is already done on magento 2.4 with the help of “AdminClickCreateOrderButtonOnEditCustomerPageActionGroup” action group.

Since the intent of this PR is already been taken care in magento 2.4, hence closing this PR.

Please reopen and update if you wish to continue.

Thank you for your contribution!

added AdminClickCreateOrderOnEditCustomerPageActionGroup

30d6370

magento-engcom-team added Component: Customer Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 6, 2021

m2-community-project bot added the Progress: pending review label Oct 6, 2021

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 7, 2021

edenduong self-requested a review October 8, 2021 08:41

Merge branch '2.4-develop' into add-AdminClickCreateOrderOnEditCustom…

5b77071

…erPageActionGroup

m2-community-project bot assigned edenduong Oct 22, 2021

edenduong approved these changes Oct 22, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Oct 22, 2021

sidolov requested changes Nov 24, 2021

View reviewed changes

m2-community-project bot assigned sidolov Nov 24, 2021

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Nov 24, 2021

Merged 2.4-develop and resolved conflicts

bd49efb

m2-community-project bot added Progress: needs update and removed Progress: on hold labels Feb 16, 2022

Merged 2.4-develop

740670b

Merge remote-tracking branch 'magento2/2.4-develop' into add-AdminCli…

4118467

…ckCreateOrderOnEditCustomerPageActionGroup

Merge remote-tracking branch 'magento2/2.4-develop' into add-AdminCli…

350fd76

…ckCreateOrderOnEditCustomerPageActionGroup

engcom-Charlie closed this Mar 9, 2022

m2-community-project bot removed Progress: needs update labels Mar 9, 2022

[MFTF] AdminClickCreateOrderOnEditCustomerPageActionGroup adding #34260

[MFTF] AdminClickCreateOrderOnEditCustomerPageActionGroup adding #34260

Uh oh!

Conversation

AnnaAPak commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Pull Requests

Uh oh!

m2-assistant bot commented Oct 6, 2021

Uh oh!

AnnaAPak commented Oct 6, 2021

Uh oh!

magento-automated-testing bot commented Oct 6, 2021

Uh oh!

sidolov commented Oct 14, 2021

Uh oh!

magento-automated-testing bot commented Oct 14, 2021

Uh oh!

sidolov commented Oct 15, 2021

Uh oh!

magento-automated-testing bot commented Oct 15, 2021

Uh oh!

sidolov commented Oct 18, 2021

Uh oh!

magento-automated-testing bot commented Oct 18, 2021

Uh oh!

magento-engcom-team commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Feb 16, 2022

Uh oh!

engcom-Charlie commented Feb 21, 2022

Uh oh!

magento-automated-testing bot commented Feb 21, 2022

Uh oh!

engcom-Charlie commented Feb 21, 2022

Uh oh!

magento-automated-testing bot commented Feb 21, 2022

Uh oh!

engcom-Charlie commented Feb 21, 2022

Uh oh!

magento-automated-testing bot commented Feb 21, 2022

Uh oh!

engcom-Charlie commented Feb 22, 2022

Uh oh!

magento-automated-testing bot commented Feb 22, 2022

Uh oh!

engcom-Charlie commented Feb 22, 2022

Uh oh!

magento-automated-testing bot commented Feb 22, 2022

Uh oh!

engcom-Charlie commented Feb 22, 2022

Uh oh!

magento-automated-testing bot commented Feb 22, 2022

Uh oh!

engcom-Charlie commented Feb 23, 2022

Uh oh!

magento-automated-testing bot commented Feb 23, 2022

Uh oh!

engcom-Charlie commented Feb 24, 2022

Uh oh!

magento-automated-testing bot commented Feb 24, 2022

Uh oh!

engcom-Charlie commented Feb 28, 2022

Uh oh!

magento-automated-testing bot commented Feb 28, 2022

Uh oh!

engcom-Charlie commented Mar 9, 2022

Uh oh!

engcom-Charlie commented Mar 9, 2022

Uh oh!

Uh oh!

AnnaAPak commented Oct 6, 2021 •

edited

Loading