Skip to content

[MFTF] Updating with AdminCheckFirstCheckboxInAddProductsToOptionPanelGridActionGroup #33703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 3, 2022
Merged

[MFTF] Updating with AdminCheckFirstCheckboxInAddProductsToOptionPanelGridActionGroup #33703

merged 9 commits into from
Feb 3, 2022

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Aug 6, 2021

Description (*)

Tests have been updated with AdminCheckFirstCheckboxInAddProductsToOptionPanelGridActionGroup

#33526

Please, note: the test is dependent on #33526

@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2021

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Bundle Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 6, 2021
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Aug 6, 2021

@magento run Semantic Version Checker, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Aug 6, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Aug 6, 2021

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 28, 2021
sidolov
sidolov requested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnaAPak please, resolve merge conflicts

@engcom-Charlie engcom-Charlie self-assigned this Jan 5, 2022
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Merge remote-tracking branch 'magento2/2.4-develop' into add-AdminChe…
3b409bd 
…ckFirstCheckboxInAddProductsToOptionPanelGridActionGroup
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

I have merged latest 2.4-develop into this PR branch.

The functional tests which are failing now, are not part of the PR changes or not failing because of any PR related change. Hence moving the PR in Merge in Progress.

Below tests are failing:

  1. app/code/Magento/CurrencySymbol/Test/Mftf/Test/AdminCheckCurrencyConverterApiConfigurationTest.xml
  2. app/code/Magento/InstantPurchase/Test/Mftf/Test/StorefrontInstantPurchaseFunctionalityTest.xml

Thank you!

magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 3, 2022
@sidolov
ENGCOM-9388: [MFTF] Updating with AdminCheckFirstCheckboxInAddProduct…
cc61e6a 
…sToOptionPanelGridActionGroup #33703
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 98782bd into magento:2.4-develop Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov requested changes

Assignees

@sidolov sidolov

@engcom-Charlie engcom-Charlie

Labels
Component: Bundle Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnnaAPak @engcom-Charlie @sidolov @magento-engcom-team @magento-devops-reposync-svc