[MFTF] Refactoring AdminCreateCreditMemoBankTransferPaymentTest #33671

AnnaAPak · 2021-08-03T12:44:01Z

The test is refactored to improve execution time

Related Pull Requests

Please, note: the test is dependent on #33557

…hOnDeliveryPaymentMethodTest

…MethodTest' into ref-AdminCreateCreditMemoBankTransferPaymentTest

m2-assistant · 2021-08-03T12:44:04Z

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AnnaAPak · 2021-08-03T12:44:25Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-08-03T12:44:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong

Thank you for your contribution. Please check my comment. Thanks!

edenduong · 2021-08-04T14:34:13Z

app/code/Magento/Sales/Test/Mftf/Test/AdminCreateCreditMemoWithBankTransferPaymentTest.xml

+        <see selector="{{AdminCreditMemoViewTotalSection.subtotal}}" userInput="$560.00" stepKey="seeSubtotal"/>
+        <see selector="{{AdminCreditMemoViewTotalSection.adjustmentRefund}}" userInput="$5.00" stepKey="seeAdjustmentRefund"/>
+        <see selector="{{AdminCreditMemoViewTotalSection.adjustmentFee}}" userInput="$10.00" stepKey="seeAdjustmentFee"/>
+        <see selector="{{AdminCreditMemoViewTotalSection.grandTotal}}" userInput="$555.00" stepKey="assertRefundOnCreditMemoTab"/>
+        <see userInput="$$createProduct.name$$" selector="{{AdminCreditMemoViewItemsSection.productName}}" stepKey="seeProductName"/>
+        <see userInput="$$createProduct.price$$" selector="{{AdminCreditMemoViewItemsSection.productPrice}}" stepKey="seePricePerItem"/>
+        <see userInput="1" selector="{{AdminCreditMemoViewItemsSection.productQty}}" stepKey="seeQty"/>


I think it can move to new ActionGroup

edenduong · 2021-08-04T14:34:43Z

app/code/Magento/Sales/Test/Mftf/Test/AdminCreateCreditMemoWithBankTransferPaymentTest.xml

+        <actionGroup ref="StorefrontOpenMyAccountPageActionGroup" stepKey="onAccountPage"/>
+        <actionGroup ref="StorefrontClickViewOrderLinkOnMyOrdersPageActionGroup" stepKey="clickViewOrder"/>
+        <actionGroup ref="StorefrontClickRefundTabCustomerOrderViewActionGroup" stepKey="clickRefund"/>
+        <see selector="{{StorefrontCustomerOrderSection.grandTotalRefund}}" userInput="555.00" stepKey="seeGrandTotal"/>


I think it can move to new ActionGroup

edenduong · 2021-08-04T14:34:55Z

...gento/Sales/Test/Mftf/Test/AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest.xml

+        </getData>
+        <actionGroup ref="StorefrontOpenMyOrdersPageActionGroup" stepKey="clickOnMyOrders"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForOrderDetailsToLoad"/>
+        <seeElement selector="{{StorefrontCustomerOrderViewSection.orderStatusInGrid('$getOrderData.increment_id$', 'Canceled')}}" stepKey="seeOrderStatusInGrid"/>


I think it can move to new ActionGroup

@edenduong I have created the separate PR for this Action Group - please check #33727.
Thanks.

Hi @AnnaAPak , thank you. I see it. Please check other comment. I see it is not resolved now :)

AnnaAPak · 2021-10-06T13:08:05Z

@magento run Functional Tests CE

magento-automated-testing · 2021-10-06T13:08:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…PaymentTest

sidolov · 2021-10-14T19:01:25Z

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

magento-automated-testing · 2021-10-14T19:01:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-10-15T17:24:32Z

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

magento-automated-testing · 2021-10-15T17:24:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…PaymentTest

…thub.com:AnnaAPak/magento2 into ref-AdminCreateCreditMemoBankTransferPaymentTest

AnnaAPak · 2022-01-10T11:29:57Z

@edenduong sorry, I re-requested a review accidentally

…PaymentTest

AnnaAPak added 4 commits July 23, 2021 09:58

refactored to decrease execution time

deceabb

Merge branch '2.4-develop' into ref-AdminCancelTheCreatedOrderWithCas…

5144c2b

…hOnDeliveryPaymentMethodTest

Merge branch 'ref-AdminCancelTheCreatedOrderWithCashOnDeliveryPayment…

eb02d6f

…MethodTest' into ref-AdminCreateCreditMemoBankTransferPaymentTest

refactored AdminCreateCreditMemoBankTransferPaymentTest

7c7cdec

magento-engcom-team added Component: Backend Component: Payment Component: Quote Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 3, 2021

edenduong requested changes Aug 4, 2021

View reviewed changes

m2-community-project bot assigned edenduong Aug 4, 2021

m2-community-project bot added the Progress: needs update label Aug 4, 2021

edenduong added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 4, 2021

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 5, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Aug 12, 2021

AnnaAPak and others added 2 commits October 11, 2021 19:00

Merge branch '2.4-develop' into ref-AdminCreateCreditMemoBankTransfer…

84ad384

…PaymentTest

Merge branch '2.4-develop' into ref-AdminCreateCreditMemoBankTransfer…

bbab545

…PaymentTest

Merge branch '2.4-develop' into ref-AdminCreateCreditMemoBankTransfer…

f527e04

…PaymentTest

Merge branch 'ref-AdminCreateCreditMemoBankTransferPaymentTest' of gi…

8cccec6

…thub.com:AnnaAPak/magento2 into ref-AdminCreateCreditMemoBankTransferPaymentTest

AnnaAPak requested a review from edenduong January 10, 2022 11:27

Merge branch '2.4-develop' into ref-AdminCreateCreditMemoBankTransfer…

07409ee

…PaymentTest

m2-community-project bot added Progress: pending review and removed Progress: review labels Dec 7, 2022

[MFTF] Refactoring AdminCreateCreditMemoBankTransferPaymentTest #33671

Are you sure you want to change the base?

[MFTF] Refactoring AdminCreateCreditMemoBankTransferPaymentTest #33671

Uh oh!

Conversation

AnnaAPak commented Aug 3, 2021

Related Pull Requests

Uh oh!

m2-assistant bot commented Aug 3, 2021

Uh oh!

AnnaAPak commented Aug 3, 2021

Uh oh!

magento-automated-testing bot commented Aug 3, 2021

Uh oh!

edenduong left a comment

Choose a reason for hiding this comment

Uh oh!

edenduong Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

edenduong Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

edenduong Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

AnnaAPak Aug 12, 2021

Choose a reason for hiding this comment

Uh oh!

edenduong Sep 1, 2021

Choose a reason for hiding this comment

Uh oh!

AnnaAPak commented Oct 6, 2021

Uh oh!

magento-automated-testing bot commented Oct 6, 2021

Uh oh!

sidolov commented Oct 14, 2021

Uh oh!

magento-automated-testing bot commented Oct 14, 2021

Uh oh!

sidolov commented Oct 15, 2021

Uh oh!

magento-automated-testing bot commented Oct 15, 2021

Uh oh!

AnnaAPak commented Jan 10, 2022

Uh oh!

Uh oh!