Skip to content

[MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsTest #33667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 3, 2022
Merged

[MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsTest #33667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e6ed808
refactored to decrease execution time
AnnaAPak Jul 22, 2021
24c3210
Merge branch '2.4-develop' into ref-AdminCancelTheCreatedOrderWithCas…
AnnaAPak Jul 22, 2021
778b802
Merge branch '2.4-develop' into ref-AdminCancelTheCreatedOrderWithChe…
AnnaAPak Aug 3, 2021
4c8908f
refactored StorefrontVerifyOrderHistoryCommentsTest
AnnaAPak Aug 3, 2021
ed343c5
Merge branch '2.4-develop' into ref-StorefrontVerifyOrderHistoryComme…
Oct 14, 2021
4c6e9c8
Merge branch '2.4-develop' into ref-StorefrontVerifyOrderHistoryComme…
Den4ik Oct 17, 2021
550115b
33667 Merged 2.4-develop and resolved conflicts
engcom-Charlie Nov 12, 2021
00d9a6b
33667 Merged 2.4-develop and resolved conflicts
engcom-Charlie Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Quote/Test/Mftf/Data/CustomerCartData.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@
<entity name="GetOrderData" type="CustomerCart">
<var key="cart_id" entityKey="return" entityType="CustomerCart"/>
</entity>

</entities>
64 changes: 64 additions & 0 deletions app/code/Magento/Sales/Test/Mftf/Test/StorefrontOrderCommentWithHTMLTagsDisplayTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
<test name="StorefrontVerifyOrderHistoryCommentsWithHTMLTagsTest">
<annotations>
<features value="Sales"/>
<stories value="Storefront Customer Order History Comments"/>
<title value="Verify Customer Order History Comments On Storefront"/>
<description value="Verify that comment with HTML tag is displayed properly on the Order View Page on Storefront"/>
<testCaseId value="MC-42694"/>
<useCaseId value="MC-42531"/>
<severity value="MINOR"/>
<group value="Sales"/>
</annotations>
<before>
<createData entity="Simple_US_Customer" stepKey="createCustomer"/>
<createData entity="SimpleProduct2" stepKey="createProduct"/>
<createData entity="CustomerCart" stepKey="createCustomerCart">
<requiredEntity createDataKey="createCustomer"/>
</createData>
<createData entity="CustomerCartItem" stepKey="addCartItem">
<requiredEntity createDataKey="createCustomerCart"/>
<requiredEntity createDataKey="createProduct"/>
</createData>
<createData entity="CustomerAddressInformation" stepKey="addCustomerOrderAddress">
<requiredEntity createDataKey="createCustomerCart"/>
</createData>
<updateData createDataKey="createCustomerCart" entity="CustomerOrderPaymentMethod" stepKey="submitOrder">
<requiredEntity createDataKey="createCustomerCart"/>
</updateData>
</before>
<after>
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customerLogout"/>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
</after>

<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>

<actionGroup ref="AdminOpenOrderViewPageByOrderIdActionGroup" stepKey="openOrder">
<argument name="orderId" value="$createCustomerCart.return$"/>
</actionGroup>

<actionGroup ref="AdminSalesOrderCommentsActionGroup" stepKey="fillAndSaveOrderComments">
<argument name="comment" value="{{SalesOrderComments.commentWithHyperlink}}" />
</actionGroup>

<actionGroup ref="LoginToStorefrontActionGroup" stepKey="loginToStorefront">
<argument name="Customer" value="$$createCustomer$$"/>
</actionGroup>

<actionGroup ref="StorefrontClickViewOrderLinkOnMyOrdersPageActionGroup" stepKey="clickViewOrder"/>

<dontSee userInput="{{anchorTagFragment.anchorTag}}" selector="{{StorefrontCustomerOrderViewSection.orderComment}}" stepKey="dontSeeExposedHtmlCode"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think can move to action group

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edenduong I checked - there are no more tests that use this assertion. Do you think we still need create a separate Action Group here?
Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnaAPak It could be groundwork for the future :)

</test>
</tests>
3 changes: 3 additions & 0 deletions app/code/Magento/Sales/Test/Mftf/Test/StorefrontVerifyOrderHistoryCommentsTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
<useCaseId value="MC-42531"/>
<severity value="MINOR"/>
<group value="Sales"/>
<skip>
<issueId value="DEPRECATED">Use StorefrontOrderCommentWithHTMLTagsDisplayTest instead</issueId>
</skip>
</annotations>
<before>
<!-- Create customer -->
Expand Down