MFTF: Unlock Admin User Entity Test #32758

DmitryTsymbal · 2021-04-15T13:30:53Z

This PR contains a test for unlocking admin user on "Locked Users" grid

Steps to reproduce:

1 - Create Admin user

2 - Lock Admin User

3 - Find locked Admin User on "Locked Users" grid

4 - Unlock Admin User

5 - Perform Assertions

Resolved issues:

resolves [Issue] MFTF: Unlock Admin User Entity Test #34836: MFTF: Unlock Admin User Entity Test

m2-assistant · 2021-04-15T13:30:55Z

Hi @DmitryTsymbal. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

DmitryTsymbal · 2021-04-15T13:31:11Z

@magento run all tests

dmytro-ch · 2021-04-16T12:00:34Z

@magento run Functional Tests CE , Functional Tests B2B , WebAPI Tests

dmytro-ch · 2021-04-26T07:18:06Z

@magento run Functional Tests CE , Functional Tests B2B

dmytro-ch · 2021-04-26T10:13:46Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-04-26T10:13:47Z

No builds to run for your request.

dmytro-ch · 2021-04-27T07:12:53Z

@magento run all tests

dmytro-ch · 2021-04-28T18:13:23Z

@magento run all tests

Den4ik · 2021-04-28T21:31:25Z

@magento run all tests

magento-automated-testing · 2021-04-28T21:31:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

Hi @DmitryTsymbal
Please update mftf test based on console log from failed tests

Den4ik · 2021-04-28T21:52:35Z

Please update mftf test based on console log from failed tests

@DmitryTsymbal sorry, looks like reported problems is not related to changes from this PR

Den4ik · 2021-04-28T22:16:39Z

Failed test related to two-factor-auth module that don't described in "Build configuration".
Waiting for response from Core team

Den4ik · 2021-04-30T20:40:33Z

@magento run Functional Tests EE, Functional Tests B2B, Functional Test CE, Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE

magento-automated-testing · 2021-04-30T20:40:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-18T06:45:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…-user

engcom-Charlie · 2021-11-25T09:12:52Z

@magento run all tests

magento-automated-testing · 2021-11-25T09:12:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-30T10:07:27Z

Currently not looking into this PR as I am in between some other priority tasks. Will resume work on this once done with current work.

engcom-Charlie · 2021-12-16T08:04:57Z

@magento run all tests

magento-automated-testing · 2021-12-16T08:05:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…-user

engcom-Charlie · 2021-12-17T10:55:18Z

@magento create issue

engcom-Charlie · 2021-12-17T11:16:39Z

@magento run all tests

magento-automated-testing · 2021-12-17T11:16:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-12-17T13:11:31Z

@magento run Functional Tests CE, Functional Tests EE

magento-automated-testing · 2021-12-17T13:11:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-12-20T06:56:02Z

@magento run Functional Tests CE

magento-automated-testing · 2021-12-20T06:56:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-12-20T11:03:19Z

Hi @sidolov,

I have merged latest 2.4-develop branch into this PR branch and resolved all conflicts.

Previously The build phase was not successful because of issue in AdminUnlockAdminUserEntityTest.xml test case. I have fixed the issue by modifying the test title and added testCaseId in AdminUnlockAdminUserEntityTest.xml test’s annotation.

Now the build phase is successful but below tests are failing.

app/code/Magento/CatalogSearch/Test/Mftf/Test/SearchEntityResultsTest/QuickSearchWithTwoCharsEmptyResultsTest.xml
 app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerLoggingFilterTest.xml

Note: The failing test cases are working fine on my local setup.

In this PR, since complete new test case has been added and the test cases which are failing now are not part of this PR changes or not failing because of any change made in this PR moving this PR further.

Requesting @Den4ik to review the changes again hence moving it to Pending Review.

Thank You!

Den4ik · 2021-12-21T12:46:45Z

@magento run Functional Tests CE

magento-automated-testing · 2021-12-21T12:46:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-12-21T14:22:37Z

Hi @Den4ik, thank you for the review.
ENGCOM-9377 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

Unlock Admin User Entity Test

e1a8c68

magento-engcom-team added Component: User Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 15, 2021

dmytro-ch self-assigned this Apr 15, 2021

m2-community-project bot added the Progress: review label Apr 15, 2021

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 15, 2021

dmytro-ch added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Apr 26, 2021

Den4ik self-assigned this Apr 28, 2021

Den4ik requested changes Apr 28, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Apr 28, 2021

Den4ik added Progress: review and removed Progress: needs update labels Apr 28, 2021

m2-community-project bot added the Progress: on hold label Apr 28, 2021

Merge remote-tracking branch 'magento2/2.4-develop' into unlock-admin…

2dfaa8e

…-user

Merge remote-tracking branch 'magento2/2.4-develop' into unlock-admin…

a31a082

…-user

m2-assistant bot mentioned this pull request Dec 17, 2021

[Issue] MFTF: Unlock Admin User Entity Test #34836

Closed

32758-Modified the title and added testCaseId in test annotation

99ab317

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Dec 20, 2021

Den4ik approved these changes Dec 21, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing Progress: accept and removed Progress: pending review Progress: ready for testing labels Dec 21, 2021

magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 3, 2022

ENGCOM-9377: MFTF: Unlock Admin User Entity Test #32758

226e725

magento-devops-reposync-svc merged commit 6da873b into magento:2.4-develop Feb 3, 2022

MFTF: Unlock Admin User Entity Test #32758

MFTF: Unlock Admin User Entity Test #32758

Uh oh!

Conversation

DmitryTsymbal commented Apr 15, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 15, 2021

Uh oh!

DmitryTsymbal commented Apr 15, 2021

Uh oh!

dmytro-ch commented Apr 16, 2021

Uh oh!

dmytro-ch commented Apr 26, 2021

Uh oh!

dmytro-ch commented Apr 26, 2021

Uh oh!

magento-automated-testing bot commented Apr 26, 2021

Uh oh!

dmytro-ch commented Apr 27, 2021

Uh oh!

dmytro-ch commented Apr 28, 2021

Uh oh!

Den4ik commented Apr 28, 2021

Uh oh!

magento-automated-testing bot commented Apr 28, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Den4ik commented Apr 28, 2021

Uh oh!

Den4ik commented Apr 28, 2021

Uh oh!

Den4ik commented Apr 30, 2021

Uh oh!

magento-automated-testing bot commented Apr 30, 2021

Uh oh!

magento-automated-testing bot commented Nov 18, 2021

Uh oh!

engcom-Charlie commented Nov 25, 2021

Uh oh!

magento-automated-testing bot commented Nov 25, 2021

Uh oh!

engcom-Charlie commented Nov 30, 2021

Uh oh!

engcom-Charlie commented Dec 16, 2021

Uh oh!

magento-automated-testing bot commented Dec 16, 2021

Uh oh!

engcom-Charlie commented Dec 17, 2021

Uh oh!

engcom-Charlie commented Dec 17, 2021

Uh oh!

magento-automated-testing bot commented Dec 17, 2021

Uh oh!

engcom-Charlie commented Dec 17, 2021

Uh oh!

magento-automated-testing bot commented Dec 17, 2021

Uh oh!

engcom-Charlie commented Dec 20, 2021

Uh oh!

magento-automated-testing bot commented Dec 20, 2021

Uh oh!

engcom-Charlie commented Dec 20, 2021

Uh oh!

Den4ik commented Dec 21, 2021

Uh oh!

magento-automated-testing bot commented Dec 21, 2021

Uh oh!

magento-engcom-team commented Dec 21, 2021

Uh oh!

Uh oh!

DmitryTsymbal commented Apr 15, 2021 •

edited by m2-assistant bot

Loading