Skip to content

Allow to generate big number of customer on galera cluster #30990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2020
Merged

Allow to generate big number of customer on galera cluster #30990

merged 1 commit into from
Dec 24, 2020

Conversation

kandy
Copy link
Contributor

@kandy kandy commented Nov 19, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Manual testing scenarios (*)

  1. Install magento on Galera cluster ( Magento Cloud Pro for example )
  2. create profile that have 10M customer
  3. run bin/magento s:p:g path/to_custom_profile

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Allow to generate big number of customer on galera cluster #31038: Allow to generate big number of customer on galera cluster

@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2020

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@kandy
Copy link
Contributor Author

kandy commented Nov 19, 2020

@magento run all tests

@kandy kandy closed this Nov 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2020

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kandy kandy reopened this Nov 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2020

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@kandy
Copy link
Contributor Author

kandy commented Nov 20, 2020

@magento run all tests

@gabrieldagama gabrieldagama added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 24, 2020
@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 24, 2020
Closed
4 tasks
@ihor-sviziev ihor-sviziev self-assigned this Dec 1, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Award: category of expertise labels Dec 1, 2020
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Dec 1, 2020 •
edited
Loading

Failing tests looks not related to changes from this PR. Let's re-run them.
@magento run Functional Tests B2B, Integration Tests, Unit Tests

@ihor-sviziev
Copy link
Contributor

Seems like test failures not related.

@magento run Functional Tests B2B, Integration Tests, Unit Tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

ihor-sviziev
ihor-sviziev approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes form this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8508 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Delta engcom-Delta self-assigned this Dec 14, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked that existing profiles small.xmland medium.xml generate data without errrors

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Dec 14, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Dec 22, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 24, 2020
@sidolov
ENGCOM-8508: Allow to generate big number of customer on galera cluster
5b342ec 
#30990
@magento-engcom-team magento-engcom-team merged commit e18ab4e into magento:2.4-develop Dec 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2020

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Award: category of expertise Component: Setup Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Allow to generate big number of customer on galera cluster
6 participants
@kandy @gabrieldagama @ihor-sviziev @magento-engcom-team @engcom-Delta @sidolov