set correct remaining available discount amount when applying fixed p…

[sky-hub]

…rice cart rules to bundle products

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. fixes [Cart Rule] Incorrect discount amount applied for bundle products containing more than one option #30952

Manual testing scenarios (*)

1. Install Magento 2.4 with sample data
2. Create cart rule with fixed discount amount for whole cart (Ex: 50$)
3. Add a bundle product to cart (Example: http://local.magento2.com/sprite-yoga-companion-kit.html)
4. Navigate to checkout/cart page and check discount.
5. Expected result: 50$, actual: 18.85$

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sky-hub. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[eduard13]

@magento run all tests

[eduard13]

Hi @sky-hub, thank you for the following fix. According to the Definition of Done, all changes have to be covered by some automated tests. Would you be kind covering the fixed case by a test?
You may write a simple MFTF test that will pass through the Precondition steps and will check the cart discount.

Thank you.

[sky-hub]

@eduard13, sure. I will get back with a comment when tests are implemented.

Cheers

[sky-hub]

@eduard13 I had a look in the MTFT testing and I ran into a dead end.

It seems there is already a MTFT Test for bundle products in app/code/Magento/SalesRule/Test/Mftf/Test/StorefrontCartPriceRuleForBundleProductTest.xml but apparently even this test is skipped due to some issue:
<skip><issueId value="MQE-2288" /></skip>.

At this point I do not know if I should update this test, and if I do update it what is the reason behind that issue that marks the test as skipped. Do you think you can help here?

PS: Please note that my experience with MTFT is very limited.

[eduard13]

@sky-hub ahh, got your point. Based on the commit's message, it looks like there were some issues running the test on Chrome 85 version. As far as I can see, the existing test applies on Percent of product price discount, which in my opinion should also be the case for this PR (I haven't checked this case), however you may create a new one that checks the Fixed amount discount test case (having the same test case as the issue states).

What do you think?
Thank you.

[eduard13]

@magento run Integration Tests, Functional Tests B2B

[sky-hub]

@eduard13 , sounds good to me.
I'll implement a test as you suggested and get back to you when it's done

[sky-hub]

@eduard13 , test implemented.
Please let me know if there is anything else I can help with.

[eduard13]

Hi @sky-hub, thank you for the test coverage. I've left couple of comments, could you please review them?
Feel free to reach me if additional questions arise.

Thanks.

[eduard13]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[eduard13]

Additionally, could you please review the failed Functional Tests, as they might be related to your changes?
Thank you.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests B2B

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests CE

[m2-assistant]

Hi @sky-hub, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.