Skip to content

[MFTF] Add StorefrontCheckoutClickSaveAddressButtonActionGroup #30528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 15, 2020
Merged

[MFTF] Add StorefrontCheckoutClickSaveAddressButtonActionGroup #30528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8e463fe
Click save address action group
Usik2203 Oct 17, 2020
a54cc96
add Backward Compatibility
Usik2203 Oct 24, 2020
657420d
Merge branch '2.4-develop' into save-checkout-address
Usik2203 Oct 24, 2020
d804a12
Chanhed message
Usik2203 Nov 4, 2020
fad49b8
Merge branch '2.4-develop' into save-checkout-address
Usik2203 Nov 4, 2020
8d8a4bf
minor fix
Usik2203 Nov 4, 2020
170620e
Merge branch '2.4-develop' into save-checkout-address
Usik2203 Nov 9, 2020
cc82610
Merge branch '2.4-develop' into save-checkout-address
engcom-Charlie Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...to/Checkout/Test/Mftf/ActionGroup/StorefrontCheckoutClickSaveAddressButtonActionGroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="StorefrontCheckoutClickSaveAddressButtonActionGroup">
<annotations>
<description>Click Save Address button on checkout.</description>
</annotations>

<click selector="{{CheckoutShippingSection.saveAddress}}" stepKey="saveAddress"/>
<waitForPageLoad stepKey="waitForAddressSaved"/>
</actionGroup>
</actionGroups>
4 changes: 2 additions & 2 deletions ...Magento/Checkout/Test/Mftf/Test/DefaultBillingAddressShouldBeCheckedOnPaymentPageTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
<argument name="classPrefix" value="._show"/>
</actionGroup>
<!--Click "Save Addresses" -->
<click selector="{{CheckoutShippingSection.saveAddress}}" stepKey="saveAddress"/>
<waitForPageLoad stepKey="waitForAddressSaved"/>
<actionGroup ref="StorefrontCheckoutClickSaveAddressButtonActionGroup" stepKey="saveAddress"/>
<comment userInput="Adding the comment to replace waitForAddressSaved action for preserving Backward Compatibility" stepKey="waitForAddressSaved"/>
<dontSeeElement selector="{{StorefrontCheckoutAddressPopupSection.newAddressModalPopup}}" stepKey="dontSeeModalPopup"/>
<!--Select Shipping Rate "Flat Rate" and click "Next" button-->
<actionGroup ref="CheckoutSelectFlatRateShippingMethodActionGroup" stepKey="selectFlatRateShipping"/>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Checkout/Test/Mftf/Test/EditShippingAddressOnePageCheckoutTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<actionGroup ref="FillShippingAddressOneStreetActionGroup" stepKey="changeAddress">
<argument name="address" value="UK_Not_Default_Address"/>
</actionGroup>
<click selector="{{CheckoutShippingSection.saveAddress}}" stepKey="saveNewAddress"/>
<actionGroup ref="StorefrontCheckoutClickSaveAddressButtonActionGroup" stepKey="saveNewAddress"/>

<!--Select Shipping Rate-->
<scrollTo selector="{{CheckoutShippingMethodsSection.next}}" stepKey="scrollToShippingRate"/>
Expand Down
5 changes: 2 additions & 3 deletions app/code/Magento/Checkout/Test/Mftf/Test/OnePageCheckoutAsCustomerUsingNewAddressTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@
<actionGroup ref="FillShippingAddressOneStreetActionGroup" stepKey="changeAddress">
<argument name="address" value="UK_Not_Default_Address"/>
</actionGroup>
<click selector="{{CheckoutShippingSection.saveAddress}}" stepKey="saveNewAddress"/>
<waitForPageLoad stepKey="waitForAddressSaving"/>

<actionGroup ref="StorefrontCheckoutClickSaveAddressButtonActionGroup" stepKey="saveNewAddress"/>
<comment userInput="Adding the comment to replace waitForAddressSaving action for preserving Backward Compatibility" stepKey="waitForAddressSaving"/>
<!-- Click next button to open payment section -->
<actionGroup ref="StorefrontCheckoutClickNextOnShippingStepActionGroup" stepKey="clickNext"/>

Expand Down
4 changes: 2 additions & 2 deletions ...Checkout/Test/Mftf/Test/StorefrontCustomerPlaceOrderWithNewAddressesThatWasEditedTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
</actionGroup>

<!--Click "Save Addresses" -->
<click selector="{{CheckoutShippingSection.saveAddress}}" stepKey="saveAddress"/>
<waitForPageLoad stepKey="waitForAddressSaved"/>
<actionGroup ref="StorefrontCheckoutClickSaveAddressButtonActionGroup" stepKey="saveAddress"/>
<comment userInput="Adding the comment to replace waitForAddressSaved action for preserving Backward Compatibility" stepKey="waitForAddressSaved"/>
<dontSeeElement selector="{{StorefrontCheckoutAddressPopupSection.newAddressModalPopup}}" stepKey="dontSeeModalPopup"/>

<!--Select Shipping Rate "Flat Rate"-->
Expand Down
5 changes: 2 additions & 3 deletions ...Mftf/Test/StorefrontTaxQuoteCheckoutTest/StorefrontTaxQuoteCheckoutLoggedInSimpleTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,8 @@
<argument name="Address" value="US_Address_CA"/>
<argument name="classPrefix" value="._show"/>
</actionGroup>
<click stepKey="saveAddress" selector="{{CheckoutShippingSection.saveAddress}}"/>

<waitForPageLoad stepKey="waitForAddressSaved"/>
<actionGroup ref="StorefrontCheckoutClickSaveAddressButtonActionGroup" stepKey="saveAddress"/>
<comment userInput="Adding the comment to replace waitForAddressSaved action for preserving Backward Compatibility" stepKey="waitForAddressSaved"/>
<see stepKey="seeAddress2" selector="{{CheckoutShippingSection.selectedShippingAddress}}" userInput="{{SimpleTaxCA.state}}"/>
<actionGroup ref="StorefrontCheckoutClickNextOnShippingStepActionGroup" stepKey="clickNext2"/>

Expand Down