-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix used in entities of the same type are displayed separately in delete warning #29490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Nazar65. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request @Nazar65 ! Please take a look at my comment
$.each(usedIn, function (entityName, number) { | ||
count++; | ||
message += entityName + '(' + number + ')'; | ||
message += count !== Object.keys(usedIn).length ? ', ' : '.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better readable if the object will be converted to an array and then rendered using .join(', ') + '.'
Main affected functionality is covered by MFTF tests |
@magento run all tests |
Hi @sivaschenko, thank you for the review. |
✔️ QA Passed Counts of asset usages is aggregated by entity type |
…rately in delete warning #29490
Hi @Nazar65, thank you for your contribution! |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Counts of asset usages should be aggregated by entity type:
Categories(2)
- only oneCategories
item should be displayed in the warning messageQuestions or comments
Contribution checklist (*)