Skip to content

Fix used in entities of the same type are displayed separately in delete warning #29490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 12, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Used in entities of the same type are displayed separately in delete warning adobe-stock-integration#1749

Manual testing scenarios (*)

  1. Add an image from media gallery to a category
  2. Add another image from media gallery to a category
  3. Try to delete both images together from the media gallery
  4. See the delete confirmation popup

Counts of asset usages should be aggregated by entity type: Categories(2) - only one Categories item should be displayed in the warning message

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Golf
Copy link
Contributor

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 12, 2020

@magento run all tests

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @Nazar65 ! Please take a look at my comment

$.each(usedIn, function (entityName, number) {
count++;
message += entityName + '(' + number + ')';
message += count !== Object.keys(usedIn).length ? ', ' : '.';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better readable if the object will be converted to an array and then rendered using .join(', ') + '.'

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 12, 2020
@ghost ghost assigned sivaschenko Aug 12, 2020
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 12, 2020
@sivaschenko
Copy link
Member

Main affected functionality is covered by MFTF tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 13, 2020

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8004 has been created to process this Pull Request

@engcom-Lima
Copy link
Contributor

engcom-Lima commented Aug 13, 2020

✔️ QA Passed

Counts of asset usages is aggregated by entity type
Screenshot_84
Manual testing scenario

@engcom-Lima engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Used in entities of the same type are displayed separately in delete warning
5 participants