#257: create new id_v2 option

[mmezhensky]

Description (*)

This PR extends product schema and added new identifier "id_v2"

Solution Architecture

Related Pull Requests

Fixed Issues (if relevant)

1. Single mutation for adding products to cart

Manual testing scenarios (*)

query {
  products(filter: { price: { from: "0.00001" } }) {
    items {
      sku

      ... on CustomizableProductInterface {
        options {
          option_id
          title
          
          ... on CustomizableRadioOption {
            title
            option_id
            selected_option: value {
              option_type_id
              uid
            }
          }
          
          ... on CustomizableDropDownOption {
            title
            option_id
            selected_option: value {
              option_type_id
              uid
            }
          }
          
          ... on CustomizableMultipleOption {
            option_id
            title
            selected_option: value {
              option_type_id
              uid
            }
          }
          
          ... on CustomizableCheckboxOption {
            option_id
            title
            selected_option: value {
              option_type_id
              uid
            }
          }
          
          ... on CustomizableAreaOption {
            option_id
            title
            entered_option: value {
              uid
            }
          }
          
          ... on CustomizableFieldOption {
            option_id
            title
            entered_option: value {
              uid
            }
          }
          
          ... on CustomizableFileOption {
            title
            option_id
            entered_option: value {
              uid
            }
          }
            
          ... on CustomizableDateOption {
            title
            option_id
            entered_option: value {
              uid
            }
          }
        }
      }
      
      ... on ConfigurableProduct {
        variants {
          attributes {
            label
            value_index
            uid
          }
        }
      }
      
      ... on DownloadableProduct {
        downloadable_product_links {
          title
          uid
        }
      }
      
      ... on BundleProduct {
        items {
          title
          options {
            uid
          }
        }
      }
    }
  }
}

Questions or comments

⚠️ For your information, that we have to use aliases (selected_options, entered_options), because both cases have a conflicting return type for value.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mmezhensky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[eduard13]

@magento run Static Tests

[eduard13]

@magento run Static Tests

[rogyar]

Looks good to me. Let's wait for the final decision regarding the bundle product options with quantity

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7608 has been created to process this Pull Request

[prabhuram93]

Note: We can update the architecture document, but occurrences of id_v2 should be an ID type, not a String. This allows us to change the format of the ID later, and also signals to developers that they're getting an opaque value, rather than a string they can perform some operations on.

We're finishing up formalizing these guidelines, and would be great to get this in

On the same lines, ID should be a mandatory field. Would be great if we can update this on the schema.

Need to update the field type from "string" to ID!. Also this deviates from the architecture document, but it is a valuable change.

[eduard13]

@magento run WebAPI Tests, Static Tests, Integration Tests, Unit Tests

[eduard13]

@magento run all tests
Hi @prabhuram93, @DrewML thank you for the suggestions, the implementation has been adjusted by renaming it to uid and making it a mandatory field. Please let me know if I missed anything.
Thank you.

[prabhuram93]

@magento run all tests
Hi @prabhuram93, @DrewML thank you for the suggestions, the implementation has been adjusted by renaming it to uid and making it a mandatory field. Please let me know if I missed anything.
Thank you.

Looks good! Thank you @eduard13

[m2-assistant]

Hi @mmezhensky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.