Skip to content

Static Content Deploy - Sort JS Translations to have them in the same order on every build #24828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

andrey-legayev
Copy link
Contributor

Description (*)

We've faced an issue on BitBucket Pipelines: every build had own unique order of JS translations.
We couldn't see the real diff between builds because of it.
Simple alphabetical sorting of translations resolves this issue.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… order on every build

We've faced an issue on BitBucket Pipelines: every build had own unique order of JS translations.
We couldn't see the real diff between builds because of it.
Simple alphabetical sorting of translations resolves this issue.
@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2019

Hi @andrey-legayev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost
Copy link

ghost commented Oct 2, 2019

@andrey-legayev unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@ihor-sviziev ihor-sviziev self-assigned this Oct 2, 2019
@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5990 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

Similar related issue here: #23324 (comment)

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 4, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 8, 2019
@magento-engcom-team magento-engcom-team merged commit b52dc0c into magento:2.3-develop Oct 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @andrey-legayev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants