magento/magento2#23054

[mamsincl]

Description (*)

Extending Magento/Cron module with functionality of being able to close the orphan/stale running cron tasks (schedules) which been started before, but somehow stopped running

Fixed Issues (if relevant)

1. Fixes Cron job not running after crashed once #23054 : Cron job not running after crashed once

Manual testing scenarios (*)

preconditions:

1. ps command availability on server
2. php bin/magento setup:upgrade to apply modifications in database
3. run php bin/magento cron:run multiple time (or be sure that crontab does the same) to get the necessary data for process schedules

(scenario a)

1. change "success" to "running" on couple of job on cron_schedule table
2. run php bin/magento cron:run
3. check the modified rows

(scenario b)

1. run php bin/magento cron:run on CLI
2. shut down/restart the server from a different console before getting back the prompt
   https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-hostname.html

Questions or comments

If you using multiple instances or in cloud environment, be sure that you have set up the hostname(s) of your instance(s) (eg. https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-hostname.html) in prior to avoid false negative match if you checking the hostnames as well

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mamsincl. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-cicd2]

All committers have signed the CLA.

[mamsincl]

Hello @magento-engcom-team, @buskamuza and @tariqjawed83 ,

I do not know If you ever checking tests results if any is failing, but - since I not even touch it - Unit Tests build errors came from original branch.
Also unable to do anything with the suggested version increase in Semantic Version Checker build, since I had to implement those modifications into (even new) files to cover everything (setting with default value, language file, etc)

The failing of Static Tests build is coming from my additions, the reasons are:

• Magento\Test\Integrity\ObserverImplementationTest is failing since my main function - which is responsible for clearing the database - is public to give the chance to the integrators to implement their own solution (there are multiple workarounds already available to solve the issue)
• Magento\Test\Php\LiveCodeTest is failing mainly of using shell_exec command: the reason of using it, since Magento Shell class implements exec php command to execute console command - but often happening that the output (of exec) just coming back truncated which happened during development process ..... that is the reason of using forbidden and discouraged php functions
  I am not too keen, but can re-implement Magento\Framework\Shell if necessary even with possible issue of the command output - or even extending Shell class with a new public function to implement shell_exec function (but this also will failing static test with the same issue)

[mamsincl]

Hi @magento-engcom-team @magento-cicd2,

Can you review my comments and react as well, please.

Thanks,
Robert

[brucemead]

Any update on this one please?

[gabrieldagama]

Hi @mamsincl, thanks for your contribution and sorry for the delay in processing it.

I'm not sure if cleaning of orphan/stale jobs from the cronjob schedule table is a good idea, we are basically masking the problem, and by removing that probably the developer won't even be aware that there could be a problem. Usually, this kind of issue happens when something needs to be fixed, so I guess it would be better something that improves developer visibility on such problems.

I'm not sure if you have seen this but we have this proposal https://github.com/magento/architecture/pull/171/files, which has really nice ideas on how to make cronjob more reliable, if you are interested in this we could start some discussion on how to start such implementation.

Please let me know your thoughts.

Thanks.

[gabrieldagama]

Closing this PR due to contributor inactivity, if you still want to work on this please feel free to reopen it. Thank you!

[m2-assistant]

Hi @mamsincl, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.