Skip to content

Fix lib-button-as-link not using color argument #24476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2019
Merged

Fix lib-button-as-link not using color argument #24476

merged 1 commit into from
Sep 10, 2019

Conversation

Leland
Copy link
Contributor

@Leland Leland commented Sep 5, 2019 •
edited
Loading

Description (*)

.lib-button-as-link(); was only using its @_link-color for [disabled] variants. It was also inefficiently emitting both the default .lib-link() hover colors, and the mixin's own provided @_link-color-hover variant.

Let's bring both arguments into the actual .lib-link() call instead.

Manual testing scenarios (*)

  1. Use .lib-button-as-link(@_link-color: @color-white)
  2. Observe that outputted styles do not change link color to white

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Leland
Fix lib-button-as-link not using color argument
c536350 
.lib-button-as-link(); was only using its @_link-color for disabled
variants. It was also inefficiently emitting both the default .lib-link()
hover colors, and the mixin's own provided @_link-color-hover
variant.

Let's bring both arguments into the actual .lib-link() call 
instead.
@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @Leland. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Leland
Copy link
Contributor Author

Leland commented Sep 5, 2019

CLA signed 😄

@rodrigowebjump rodrigowebjump self-requested a review September 5, 2019 19:45
@rodrigowebjump rodrigowebjump self-assigned this Sep 5, 2019
@rodrigowebjump
Copy link
Member

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

@rodrigowebjump
Copy link
Member

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-24476.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned VladimirZaets Sep 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5800 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@Leland thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Sep 9, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

magento-engcom-team pushed a commit that referenced this pull request Sep 10, 2019
@sidolov
ENGCOM-5800: Fix lib-button-as-link not using color argument #24476
477472a
@magento-engcom-team magento-engcom-team merged commit c536350 into magento:2.3-develop Sep 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2019

Hi @Leland, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 10, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
@Leland Leland deleted the fix/lib-button branch September 10, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@rodrigowebjump rodrigowebjump Awaiting requested review from rodrigowebjump

Assignees

@rodrigowebjump rodrigowebjump

@VladimirZaets VladimirZaets

@engcom-Alfa engcom-Alfa

Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Something Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@Leland @magento-cicd2 @rodrigowebjump @magento-engcom-team @engcom-Alfa @VladimirZaets @sidolov