Mark Elasticsearch 6 configs as sensitive

[aapokiiso]

Description (*)

At the moment, app:config:dump writes ES6 configs to app/etc/config.php. Marking the configs sensitive moves them to app/etc/env.php.

This is copied from the main Magento Elasticsearch module,
where the sensitive configs have already been set for Elasticsearch 5.

Fixed Issues (if relevant)

Manual testing scenarios (*)

To reproduce the problem:

1. Run bin/magento app:config:dump on a Magento instance with Elasticsearch 6 configured.
2. Check app/etc/config.php. You should see the ES6 connection configs there, even though they are environment specific.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @aapokiiso. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-5788 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @aapokiiso, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.