Skip to content

fix issue #24366 - Updating cart quantity #24380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 10, 2019

Conversation

GDauer
Copy link
Contributor

@GDauer GDauer commented Aug 31, 2019

Description (*)

This Pull Request fix Updating cart quantity, causes wrong error message to be displayed when backorders is involved. Internal ticket MC-19752

Fixed Issues (if relevant)

  1. Updating cart with quantity that results in error, causes wrong error message to be displayed when backorders involved. #24366: Updating cart with quantity that results in error, causes wrong error message to be displayed when backorders involved.

Manual testing scenarios (*)

  1. Deploy 2.3-develop
  2. Create a test Category
  3. Create test product in test category.
  4. Set the stock product to Qty = 10
  5. Allows Backorders with Notify to the product
  6. Set Max in cart = 30 in test product.
  7. Go to frontend and add 10 items to cart
  8. Verify no warning messages
  9. Change quantity to 25 and Update cart
  10. Verify backorder warning of 15 items backordered
  11. Change quantity to 35 and Update cart

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 31, 2019

Hi @GDauer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@GDauer
Copy link
Contributor Author

GDauer commented Aug 31, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @GDauer. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @GDauer, here is your new Magento instance.
Admin access: https://pr-24380.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@GDauer GDauer changed the title bugfix/MAGE24366 fix issue #24366 Aug 31, 2019
@rodrigowebjump rodrigowebjump self-requested a review August 31, 2019 00:38
@rodrigowebjump rodrigowebjump self-assigned this Aug 31, 2019
@rodrigowebjump rodrigowebjump changed the title fix issue #24366 fix issue #24366 - Updating cart quantity Aug 31, 2019
@gwharton
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gwharton, here is your new Magento instance.
Admin access: https://pr-24380.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@gwharton
Copy link
Contributor

gwharton commented Aug 31, 2019

@GDauer Solution Looks good. Test failures need resolving though.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-5790 has been created to process this Pull Request
✳️ @rodrigowebjump, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@GDauer thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2019

Hi @GDauer, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 10, 2019
@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
@GDauer GDauer deleted the bugfix branch October 27, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants