magento/magento2#: Replace deprecated addError, addSuccess, addException methods in Magento/Customer/Controller/Account/CreatePost.php

[atwixfirster]

Description (*)

Pull request replaces deprecated addError, addSuccess, addException methods in Magento/Customer/Controller/Account/CreatePost.php of Magento_Customer module:

addError -> addErrorMessage
addSuccess -> addSuccessMessage
addException -> addExceptionMessage

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Thank you!

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[dmytro-ch]

@atwixfirster , could you please check the failed integration tests.
There is a difference in expected results due to escaped characters after using the new methods.

[atwixfirster]

@atwixfirster , could you please check the failed integration tests.

done

@dmytro-ch, could you please review?

Thank you!

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-5730 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

[sidolov]

@atwixfirster looks like the simple implementation with just messages became a really complex, could you please clarify why we need to use additional templates for simple messages that can be inlined and used in addSuccessMessage method?

[atwixfirster]

@atwixfirster looks like the simple implementation with just messages became a really complex, could you please clarify why we need to use additional templates for simple messages that can be inlined and used in addSuccessMessage method?

Hi, @sidolov !

I will try to explain on the following example.

Preconditions:

1. Go to CUSTOMERS > Customer Configuration > Create New Account Options on the back-end side
2. Set option Require Emails Confirmation = Yes

Steps to reproduce:

1. Register a new customer on FE side
2. With addComplexSuccessMessage you will get:

3. With addSuccessMessage output result will be a slightly different:

Thank you!

[atwixfirster]

@atwixfirster looks like the simple implementation with just messages became a really complex,...

@sidolov , you can see the same implementations in the Magento_Wishlist module:

• https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Wishlist/etc/frontend/di.xml#L38
• https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Wishlist/Controller/Index/Add.php#L134

Thank you!

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.