Resolve model Rss extends wrong class

[edenduong]

Description (*)

Please see: app/code/Magento/Review/Model/Rss.php

• The __construct() is override the parent class, but it doesn't call the parent::__construct().

Fixed Issues (if relevant)

Manual testing scenarios (*)

Unit test covered.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sidolov]

Unfortunately, we can't remove inheritance according to our Backward Compatible Development Guide. Someone can use Rss model in 3d party code and use methods from the \Magento\Framework\Model\AbstractModel
It's better to call the parent constructor here, looks like that call was missed during the refactoring.

[edenduong]

@sidolov: I have changed it. Now, I think it following the Backward Compatible Development Guide.
Thank you very much.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5671 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.