Skip to content

fix function return type #24142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2019
Merged

fix function return type #24142

merged 1 commit into from
Aug 16, 2019

Conversation

maslii
Copy link
Member

@maslii maslii commented Aug 15, 2019

Description (*)

Function getLastPageNumber supposed to return Integer type, but actual result most of the time is of type Float.

Manual testing scenarios (*)

  1. Any usage of method getLastPageNumber of Framework/Data/Collection class.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2019

Hi @maslii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

In case you'd like to rerun tests use the following comments:

  • @magento run all tests - run all tests
  • @magento run { check name } - run a single test job (check name example: Static Tests build)

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 15, 2019

CLA assistant check
All committers have signed the CLA.

@ghost ghost assigned swnsma Aug 15, 2019
@swnsma swnsma added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5628 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@maslii thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost ghost assigned VladimirZaets Aug 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5628 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit cfd9e63 into magento:2.3-develop Aug 16, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2019

Hi @maslii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Data Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants