Skip to content

Resolve Missing "expand/collapse" icon in paypal setting (issue 24118) #24119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Missing "expand/collapse" icon in paypal setting #24118: Missing "expand/collapse" icon in paypal setting

Solution: fix in style.css of Paypal module

Fixed Issues (if relevant)

  1. Missing "expand/collapse" icon in paypal setting #24118: Missing "expand/collapse" icon in paypal setting

Manual testing scenarios (*)

  1. Go to backend
  2. Stores->Configuration
  3. Sales->Payment Methods
  4. Check the screen. No "expand/collapse" icon

image

Expected result

Have the icon:

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 13, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

In case you'd like to rerun tests use the following comments:

  • @magento run all tests - run all tests
  • @magento run { check name } - run a single test job (check name example: Static Tests build)

For more details, please, review the Magento Contributor Guide documentation.

@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-24119.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong requested a review from swnsma August 13, 2019 09:24
@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-5609 has been created to process this Pull Request
✳️ @josefbehr, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 14, 2019
@josefbehr josefbehr added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 15, 2019
@josefbehr josefbehr removed the request for review from swnsma August 15, 2019 13:50
@magento-engcom-team magento-engcom-team merged commit 2895106 into magento:2.3-develop Aug 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "expand/collapse" icon in paypal setting
5 participants