Skip to content

Resolve "Number of results" and "Number of Uses" in edit "Search Term" missing validate number (issue 24100) #24101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve "Number of results" and "Number of Uses" in edit "Search Term" missing validate number  #24100: "Number of results" and "Number of Uses" in edit "Search Term" missing validate number

Solution: Add class "required-entry validate-digits validate-zero-or-greater" in app/code/Magento/Search/Block/Adminhtml/Term/Edit/Form.php

Fixed Issues (if relevant)

  1. "Number of results" and "Number of Uses" in edit "Search Term" missing validate number  #24100: "Number of results" and "Number of Uses" in edit "Search Term" missing validate number

Manual testing scenarios (*)

  1. Go to frontend
  2. At the right top, in "Search Entire Store Here", enter "gggg", and search
  3. Go to Backend
  4. Marketing->Search Terms
  5. Choose record "gggg"
  6. In "Number of results" and "Number of Uses", fill "one"
  7. Click "Save Search"

image

Expected result

  1. Don't allow to save

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

In case you'd like to rerun tests use the following comments:

  • @magento run all tests - run all tests
  • @magento run { check name } - run a single test job (check name example: Static Tests build)

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Aug 11, 2019
@rogyar rogyar added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix labels Aug 11, 2019
@rogyar
Copy link
Contributor

rogyar commented Aug 11, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-24101.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5587 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 13, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 14, 2019
… "Search Term" missing validate number (issue 24100) magento#24101
@magento-engcom-team magento-engcom-team merged commit 20f88ec into magento:2.3-develop Aug 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Number of results" and "Number of Uses" in edit "Search Term" missing validate number
5 participants