Skip to content

Set isMultiShipping to 0 in database so it can be used correctly by rest api requests on checkout page #24072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

websnap
Copy link

@websnap websnap commented Aug 8, 2019

Description (*)

After user visits multishipping checkout page magento sets is_multi_shipping flag to 1 in database. When user will return to the website and go to the regular checkout page, is_multi_shipping flag will be still contain value 1. It is makes it useless for checkout ajax requests. e.g. get shipping methods list.
Current PR will fix it.

Manual testing scenarios (*)

  1. Add products to the shopping cart
  2. Go to the shopping cart page
  3. Click "Check Out with Multiple Addresses". Go to Multishipping checkout page
  4. Check that in the database table "quote" column "is_multi_shipping" = 1
  5. Click "Back to Shopping Cart"
  6. Click "Proceed to Checkout". Go to regular checkout page
  7. Check that in the database table "quote" column "is_multi_shipping" = 0

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2019

Hi @websnap. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 8, 2019

CLA assistant check
All committers have signed the CLA.

@swnsma
Copy link
Contributor

swnsma commented Aug 9, 2019

Motivation: magento/inventory#2358
Need to figure out if Quote Multi Shipping or not to provide correct shipping methods.

@swnsma swnsma self-requested a review August 12, 2019 10:12
@swnsma swnsma self-assigned this Aug 12, 2019
@swnsma swnsma added the Partner: ISM eCompany Pull Request is created by partner ISM eCompany label Aug 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5598 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@websnap thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@swnsma swnsma added partners-contribution Pull Request is created by Magento Partner Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Aug 12, 2019
@engcom-Alfa engcom-Alfa self-assigned this Aug 20, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 21, 2019
magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2019
@magento-engcom-team magento-engcom-team merged commit 9140fab into magento:2.3-develop Aug 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2019

Hi @websnap, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Multishipping Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants