ImportExport module missing some translation #24017

edenduong · 2019-08-05T09:56:18Z

Description (*)

ImportExport has some "fixed" string. And it can not be translated.

Solution: use :

echo __('Invalid response');

and echo __('Invalid data');

instead of hard fix string.

Fixed Issues (if relevant)

Manual testing scenarios (*)

Check the translate word when the message was triggered. ("Invalid data")

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-08-05T09:56:20Z

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-engcom-team · 2019-08-07T09:18:40Z

Hi @rogyar, thank you for the review.
ENGCOM-5551 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2019-08-07T12:56:24Z

Hi @edenduong !

I've checked PR and looks like changes doesn't solve the problem.

Actual Result:
The message was not translated

@edenduong Could you take a look, please?

Thanks!

edenduong · 2019-08-08T07:28:17Z

@engcom-Alfa: I am sorry about that. I have changed the source code. Please check it again.
@rogyar: Please review my new changes.

Have a nice day!

edenduong · 2019-08-13T08:46:12Z

@rogyar: Could you please review my new changes?

sidolov · 2019-08-14T15:57:19Z

app/code/Magento/ImportExport/view/adminhtml/templates/export/form/before.phtml

@@ -89,7 +89,7 @@ require([
            form.action   = oldAction;
        } else {
            alert({
-                content: 'Invalid data'
+                content: '<?= $block->escapeHtml(__('Invalid data')); ?>'


Please, use mage/translation instead of block method

@sidolov : I don't know the reason but the first time of this PR, I use the mage/translate. And it can not translate. Could you please try it?

sidolov · 2019-08-14T15:57:24Z

app/code/Magento/ImportExport/view/adminhtml/templates/import/form/before.phtml

@@ -209,7 +209,7 @@ require([
        postToFrameProcessResponse: function(response) {
            if ('object' != typeof(response)) {
                alert({
-                    content: 'Invalid response'
+                    content: '<?= $block->escapeHtml(__('Invalid response')); ?>'


Please, use mage/translation instead of block method

@sidolov : I don't know the reason but the first time of this PR, I use the mage/translate. And it can not translate. Could you please try it?

escapeHtml method does not translate strings, it just removes special characters from the string.

@sidolov : Yes, but __(‘...’) translate the string. And the code now can translate. I use escapeHtml because I make it similar many place in Magento now. It is strange because the code escapeHtml of ‘fixed’ string. I can remove that code if you want.
I mean the mage/translate can not translate in this case (I don’t know but I may be a bug of mage/translate) . So I use translate by ‘block’.

@sidolov :I think escapeHtml to Secure the change of csv file can include the “html” code. So it is the reason escapeHtml of __(‘...’) function.

@edenduong looks like @engcom-Alfa didn't clear the cache after changes were applied. mage/translate works similar to __() function on the backend. Please, revert back changes to use mage/translate and I'll accept your PR. I'm sorry for the inconvenience.

@sidolov : I don't know the reason but mage/translate can not translate. (I have cleared cache). I tested it. Could you please try to edit it?

@edenduong you are right looks like mage/translate does not work in phtml file, it's working on js only. Thank you for the clarification!

magento-engcom-team · 2019-08-23T18:29:35Z

Hi @VladimirZaets, thank you for the review.
ENGCOM-5551 has been created to process this Pull Request

magento-engcom-team · 2019-08-23T18:32:41Z

Hi @sidolov, thank you for the review.
ENGCOM-5551 has been created to process this Pull Request

engcom-Alfa · 2019-08-27T06:32:34Z

✔️ QA Passed

m2-assistant · 2019-08-27T22:22:24Z

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Area: Frontend Component: ImportExport Release Line: 2.3 labels Aug 5, 2019

rogyar self-assigned this Aug 7, 2019

rogyar approved these changes Aug 7, 2019

View reviewed changes

ghost added the Progress: ready for testing label Aug 7, 2019

rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 7, 2019

engcom-Alfa self-assigned this Aug 7, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 7, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Aug 7, 2019

Resolve ImportExport module missing some translation

2fbd1ed

edenduong force-pushed the 2.3-bugfix/missing_translate_import_export branch from d8437c4 to 2fbd1ed Compare August 8, 2019 07:26

Fix static test

87c8e2e

sidolov requested changes Aug 14, 2019

View reviewed changes

ghost assigned sidolov Aug 14, 2019

VladimirZaets approved these changes Aug 23, 2019

View reviewed changes

ghost assigned VladimirZaets Aug 23, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 23, 2019

sidolov approved these changes Aug 23, 2019

View reviewed changes

ghost removed the Progress: ready for testing label Aug 27, 2019

ghost added the Progress: testing in progress label Aug 27, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 27, 2019

engcom-Foxtrot self-assigned this Aug 27, 2019

ghost added Progress: accept and removed Progress: extended testing labels Aug 27, 2019

magento-engcom-team pushed a commit that referenced this pull request Aug 27, 2019

ENGCOM-5551: ImportExport module missing some translation #24017

d895667

magento-engcom-team merged commit 87c8e2e into magento:2.3-develop Aug 27, 2019

magento-engcom-team added this to the Release: 2.3.4 milestone Aug 27, 2019

ImportExport module missing some translation #24017

ImportExport module missing some translation #24017

Uh oh!

Conversation

edenduong commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 5, 2019

Uh oh!

magento-engcom-team commented Aug 7, 2019

Uh oh!

engcom-Alfa commented Aug 7, 2019

Uh oh!

edenduong commented Aug 8, 2019

Uh oh!

edenduong commented Aug 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edenduong Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edenduong Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Aug 23, 2019

Uh oh!

magento-engcom-team commented Aug 23, 2019

Uh oh!

engcom-Alfa commented Aug 27, 2019

Uh oh!

m2-assistant bot commented Aug 27, 2019

Uh oh!

Uh oh!

edenduong commented Aug 5, 2019 •

edited

Loading

edenduong Aug 14, 2019 •

edited

Loading

edenduong Aug 14, 2019 •

edited

Loading