Resolve "Currency Converter API" can not get Currency Rate

[edenduong]

Description (*)

Resolve "Currency Converter API" can not get Currency Rate.

As my inspection, https://free.currencyconverterapi.com/ now required the API key.

But now in Magento 2.3, it doesn't have the API Key config. => Missing information and can not get the rate.

Solution: Add the "API Key" config to the settings, pass the key to the API Url.

• also Process the "Error" response (to fix the issue "Currency Converter API" notify "Notice: Undefined index" when import currency rate #24007 -Notice: Undefined index )

Fixed Issues (if relevant)

1. "Currency Converter API" notify "Notice: Undefined index" when import currency rate #24007: "Currency Converter API" notify "Notice: Undefined index" when import currency rate

Manual testing scenarios (*)

- When no fill API Key

1. Go to Backend
2. Store -> Currency Rate
3. "Import Service" choose "Currency Converter API"
4. Click "Import"

Expected result

1. Notify correct error message

- When fill correct API Key

1. Get API from https://free.currencyconverterapi.com/ (by register)
2. Store->Configurations->Currency Setup
3. Currency Converter API -> API Key. Fill the API Key get from email which sent by https://free.currencyconverterapi.com/
4. Store -> Currency Rate
5. "Import Service" choose "Currency Converter API"
6. Click "Import"

Expected result

1. Get the rate successfully from currencyconverterapi

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-5574 has been created to process this Pull Request

[engcom-Alfa]

Hi @edenduong !

During testing we faced an issue.

Problem: Duplicate "Invalid Free API Key..." error message

Steps to reproduce:

1. Go to Admin->Stores->Configuration->Currency Setup;
2. Select 3 or more currencies in "Allowed Currencies" block;
3. In "Currency Converter API" block set wrong API code -> Save;
4. Go to System->Currency Rates;
5. Select "Currency Converter API" from "Import Service" dropdown;
6. Click on "Import" button;

Actual Result:

@edenduong Could you take a look?

Thanks!

[edenduong]

Hello @engcom-Alfa,

I have changed the source code. You can check it again.

Hi @swnsma : Please review my new changes. Thanks!

[swnsma]

It seems OK for me.

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-5574 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.