Skip to content

"Selected Attributes" lost selected value when filter (issue 23999) #24000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve "Selected Attributes" lost selected value when filter #23999: "Selected Attributes" lost selected value when filter

Solution: Must add "preserveSelectionsOnFilter" is "true" in the xml

Fixed Issues (if relevant)

  1. "Selected Attributes" lost selected value when filter #23999: "Selected Attributes" lost selected value when filter

Manual testing scenarios (*)

Remember: Created at least 2 dropdown attributes (color, size)

  1. Go to backend
  2. Catalog -> Product -> Add Product
  3. Fill require information
  4. Click "Create Configurations"
  5. In "Selected Attributes", select "color"
  6. Go to filter, filter "size" in "Attribute Code"
  7. Select "size"
  8. View "Selected Attributes"

Expected result

Select "Color, Size"
image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 3, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@edenduong edenduong requested a review from swnsma August 3, 2019 09:09
@edenduong edenduong changed the title "Selected Attributes" lost selected value when filter issue 23999 "Selected Attributes" lost selected value when filter (issue 23999) Aug 3, 2019
@edenduong
Copy link
Contributor Author

edenduong commented Aug 4, 2019

@sivaschenko

Seems the "Fail" functional test doesn't related to my changes.

image

It create two values are the same => fail

So is it considered pass the automation test?

@sivaschenko
Copy link
Member

@magento run Functional Tests build

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5577 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Aug 9, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@edenduong
Copy link
Contributor Author

@sidolov : Could I receive the "Bugfix award" for this PR? Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Selected Attributes" lost selected value when filter
6 participants