Skip to content

Fixed typo in deploy module README.md #23735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fixed typo in deploy module README.md #23735

merged 1 commit into from
Jul 18, 2019

Conversation

arnolds
Copy link
Contributor

@arnolds arnolds commented Jul 16, 2019

Description (*)

Fixed typo in deploy module README.md from bin/magento setup:mode:set to bin/magento deploy:mode:set.

It needed changing, because the command bin/magento setup:mode:set does not exist.

Screenshot 2019-07-16 at 21 24 18

The correct command is bin/magento deploy:mode:set.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to magento2/app/code/Magento/Deploy/README.md file.
  2. Scroll down, or search for bin/magento setup:mode:set.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2019

Hi @arnolds. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 16, 2019

CLA assistant check
All committers have signed the CLA.

@ghost ghost assigned kalpmehta Jul 16, 2019
@kalpmehta kalpmehta added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5458 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@arnolds thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Jul 18, 2019

Hi @arnolds, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants