Skip to content

23424: fixed search with 0 #23427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2019
Merged

23424: fixed search with 0 #23427

merged 3 commits into from
Jul 5, 2019

Conversation

jeysmook
Copy link
Contributor

@jeysmook jeysmook commented Jun 26, 2019

Description (*)

Fixed search with 0

Fixed Issues (if relevant)

  1. Search by keyword didn't work properly with "0" value #23424
  2. Search for 0 - doesn't work adobe-stock-integration#100

Manual testing scenarios (*)

  1. Go to admin panel
  2. Go to Catalog -> Products
  3. Search products by 0

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @jeysmook. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 26, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5402 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@jeysmook thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @jeysmook, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 5, 2019
vasilii-b pushed a commit to vasilii-b/magento2 that referenced this pull request Jul 10, 2019
…d-ms-tile-image-meta-tag

* origin/2.3-develop: (3294 commits)
  magento#23427 Fix static
  magento#23532 Fix-static-tests
  magento/magento#23500 fix funk tests
  fix validation class for max-words
  MC-17922: Date in filter area doesn't match with Active filters bar
  Fixed coding standards violations
  Updated unit test
  MC-17922: Date in filter area doesn't match with Active filters bar
  Update Framework/Mail::Message to send all emails as MIME, not just HTML emails.
  MC-17922: Date in filter area doesn't match with Active filters bar
  Removed editors from all dependable customer billing address fields
  Correct array type hints
  Fix mass detection issue
  Testing configurable option update based on product and attribute_id
  move breakpoint by -1px to make nav work correctly at viweport width of 768px
  MC-17275: Admin Down after changing store domain/cookie
  Setting right shipper street1 in addressline1
  MC-17275: Admin Down after changing store domain/cookie
  Replaced urldecode with rawurldecode that not converting + into space
  Fixed issue magento#23383
  ...
vasilii-b pushed a commit to vasilii-b/magento2 that referenced this pull request Jul 10, 2019
…lk-delete

* origin/2.3-develop: (4954 commits)
  magento#23427 Fix static
  magento#23532 Fix-static-tests
  magento/magento#23500 fix funk tests
  fix validation class for max-words
  MC-17922: Date in filter area doesn't match with Active filters bar
  Fixed coding standards violations
  Updated unit test
  MC-17922: Date in filter area doesn't match with Active filters bar
  Update Framework/Mail::Message to send all emails as MIME, not just HTML emails.
  MC-17922: Date in filter area doesn't match with Active filters bar
  Removed editors from all dependable customer billing address fields
  Correct array type hints
  Fix mass detection issue
  Testing configurable option update based on product and attribute_id
  move breakpoint by -1px to make nav work correctly at viweport width of 768px
  MC-17275: Admin Down after changing store domain/cookie
  Setting right shipper street1 in addressline1
  MC-17275: Admin Down after changing store domain/cookie
  Replaced urldecode with rawurldecode that not converting + into space
  Fixed issue magento#23383
  ...
@VladimirZaets VladimirZaets added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants