-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Fixed #19605 Don't static compile disabled modules #19989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fixed #19605 Don't static compile disabled modules #19989
Conversation
Fixed issue #19605 Don't static compile disabled modules Updated Collector.php Updated Collector.php
Hi @shikhamis11. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a557683#diff-5d7224ff8a7eb9c1bba99ebdde05119f it looks like static tests failures are going to be fixed by internal team.
Hi @orlangur, thank you for the review. |
Hi @shikhamis11, thank you for your contribution! |
Hi @shikhamis11. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Original Pull Request
#19751
Fixed issue #19605 Don't static compile disabled modules
Summary
When running static-content:deploy, there are disabled module content in pub/static.
Examples
Disable modules that have frontend resources.
Run bin/magento setup:static-content:deploy
Observe that pub/static/... contains the resources.
Contribution checklist (*)