Skip to content

[Backport] Remove unneeded, also mistyped, saveHandler from CatalogSearch indexer declaration #19984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Dec 27, 2018

Original Pull Request

#11626
Remove unneeded, also mistyped, saveHandler from CatalogSearch indexer declaration.

Description

This PR removes unneeded from Magento/CatalogSearch/etc/indexer.xml:
captura de pantalla 2017-10-22 a las 3 21 29

It's not used, and it is mistyped: no such class Magento\CatalogSearch\Model\Indexer\IndexHandler exists; it refers instead to Magento\CatalogSearch\Model\Indexer\IndexerHandler. Even it is mistyped, it works due to Magento\CatalogSearch\Model\Indexer\IndexerHandlerFactoryhandling the save handlers, and correct class name is injected into IndexerHandlerFactory via Magento/CatalogSearch/etc/di.xml:
captura de pantalla 2017-10-22 a las 3 27 03

Fixed Issues (if relevant)

#19982

Manual testing scenarios

After removing that line, everything should work as before.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: CatalogSearch Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 27, 2018
@dmytro-ch dmytro-ch requested a review from rogyar December 27, 2018 07:00
@orlangur orlangur removed the request for review from rogyar January 9, 2019 02:31
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3811 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 21, 2019

Hi @dmytro-ch, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 21, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogSearch Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants