Skip to content

[Forwardport] fix: remove disabled attribute on region list #17438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 11, 2018
Merged

[Forwardport] fix: remove disabled attribute on region list #17438

merged 1 commit into from Aug 11, 2018

Conversation

DanielRuf
Copy link
Contributor

Original Pull Request

#16955

Description

By default when a list is not populated at the beginning (eg for UK) and when we switch to another country (eg Germany) and get a populated list, the list is still disabled and we can not select any option.

Fixed Issues (if relevant)

  1. ...

Manual testing scenarios

  1. go to /customer/account/create/
  2. switch from a country with an empty region list to a country with a region list
  3. try to select a region (does not work as the input is still disabled)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@DanielRuf DanielRuf deleted the 2.3-develop-PR-port-16955 branch March 17, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants