Skip to content

[Forwardport] Replace sort callbacks to spaceship operator #17423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2018
Merged

[Forwardport] Replace sort callbacks to spaceship operator #17423

merged 1 commit into from
Aug 9, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Aug 7, 2018

Original Pull Request

#16788

Description

Small change to improve overall readability of Shipping Methods sorting

Fixed Issues (if relevant)

  1. Replace sort callbacks to spaceship operator #16788: Replace sort callbacks to spaceship operator

Manual testing scenarios

  1. Add multiple shipping methods with different Sort Orders
  2. Proceed to checkout, compare shipping methods with expected ones

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-2697 has been created to process this Pull Request

@VladimirZaets VladimirZaets changed the title Replace sort callbacks to spaceship operator [Forwardport] Replace sort callbacks to spaceship operator Aug 7, 2018
@magento-engcom-team magento-engcom-team merged commit 07402bb into magento:2.3-develop Aug 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants