Skip to content

Replaced deprecated code for Magento_SalesRule module. #17409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replaced deprecated code for Magento_SalesRule module. #17409

wants to merge 1 commit into from

Conversation

tiagosampaio
Copy link
Member

Replaced deprecated code for Magento_SalesRule module.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio
Thank you for your contribution. This pull request has been combined (merged) with #17410 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

@tiagosampaio tiagosampaio deleted the 2.3-develop-011 branch August 16, 2018 15:46
@tiagosampaio tiagosampaio restored the 2.3-develop-011 branch November 20, 2018 17:37
@tiagosampaio tiagosampaio deleted the 2.3-develop-011 branch November 20, 2018 17:39
@tiagosampaio tiagosampaio restored the 2.3-develop-011 branch April 13, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants