Skip to content

Remove dead code #17401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Remove dead code #17401

merged 1 commit into from
Aug 9, 2018

Conversation

shochdoerfer
Copy link
Member

\Magento\Cms\Model\Page::load() returns $this thus the if condition will never evaluate as false. And since there is an id check afterwards anyways we should be save. Basically applies #17400 in 2.3 develop.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

\Magento\Cms\Model\Page::load() returns $this thus the
if condition will never evaluate as false. And since
there is an id check afterwards anyways we should be
save.
@magento-engcom-team
Copy link
Contributor

Hi @shochdoerfer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @shochdoerfer. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@shochdoerfer
Copy link
Member Author

No fixing of the failing test needed? :)

@lewisvoncken lewisvoncken mentioned this pull request Oct 6, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants