Skip to content

Update CMS Page Index #17066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 7, 2018
Merged

Update CMS Page Index #17066

merged 6 commits into from
Aug 7, 2018

Conversation

hryvinskyi
Copy link
Member

@hryvinskyi hryvinskyi commented Jul 24, 2018 •
edited
Loading

Description

Remove Object Manager and add dependency injection to constructor,
Fix Code Style

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hryvinskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov self-assigned this Jul 24, 2018
sidolov
sidolov requested changes Jul 24, 2018
View reviewed changes
app/code/Magento/Cms/Controller/Index/Index.php Outdated
* @param \Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
* @var \Magento\Framework\App\Config\ScopeConfigInterface
*/
protected $scopeConfig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, try to avoid the usage of protected properties, make it private.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chanched to private.
Why do I need to use private instead of protected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't recommend to use inheritance, that why all class properties should be private. The composition is a better way to extend any logic. More information you can find in Magento Technical Guidelines

app/code/Magento/Cms/Controller/Index/Index.php Outdated
Context $context,
ScopeConfigInterface $scopeConfig,
ForwardFactory $resultForwardFactory,
Page $page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, inject new dependencies according to Magento Backward Compatible Development Guide

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to backward compatible

@hryvinskyi
Copy link
Member Author

@sidolov there are some updates?

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2655 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 4ea1070 into magento:2.2-develop Aug 7, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 7, 2018
ENGCOM-2655: Update CMS Page Index #17066
05197a6
@magento-engcom-team
Copy link
Contributor

Hi @hryvinskyi. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mage2pratik mage2pratik mentioned this pull request Aug 7, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels
Component: Cms Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@hryvinskyi @magento-engcom-team @sidolov