Skip to content

[Forwardport] Clean code #17047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Forwardport] Clean code #17047

wants to merge 6 commits into from

Conversation

torhoehn
Copy link
Contributor

Original Pull Request

#16841

Description

Just modify some code, and make it Cleaner more...

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Jul 24, 2018

@torhoehn , please, take a look at failed tests

@sidolov
Copy link
Contributor

sidolov commented Aug 9, 2018

Hi @torhoehn , tests still failing, will continue progress with this PR?

@sidolov
Copy link
Contributor

sidolov commented Aug 13, 2018

Hi @torhoehn , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants