Skip to content

[Backport] Make configfixture meaningful in ProcessCronQueueObserverTest #16844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Backport] Make configfixture meaningful in ProcessCronQueueObserverTest #16844

wants to merge 1 commit into from

Conversation

ronak2ram
Copy link
Member

Original Pull Request

#16253

Description

Filter test result collection with the cron job code defined in the config fixture. Set the schedule for every minute so that the job is scheduled regardless of the time when you run the test.

Fixed Issues (if relevant)

  1. Integration test ProcessCronQueueObserverTest.php succeeds regardless of magento config fixture #16243

Manual testing scenarios

  1. run dev/tests/integration/testsuite/Magento/Cron/Observer/ProcessCronQueueObserverTest.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…onfig fixture. Set the schedule for every minute so that the job is scheduled regardless of the time when you run the test.
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ronak2ram ronak2ram closed this Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants