Skip to content

[Forwardport] Added translation function for Magento_Braintree module's template file. #16771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 9, 2018

Conversation

sanganinamrata
Copy link
Member

Original Pull Request

#16690

Description

Added translation function for Magento_Braintree module's template file.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

sanganinamrata and others added 7 commits July 9, 2018 11:11
[Forwardport] Removed double occurrences from files.
[Forwardport] Added 'title' attribute to 'img' tag in knockout template files.
[Forwardport] Added translation function for Magento_Braintree module's template file.
@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Jul 16, 2018

Hi @sanganinamrata , looks like you pushed additional changes by mistake, please, revert.

@sidolov sidolov self-assigned this Aug 5, 2018
@sidolov sidolov requested review from sidolov and removed request for magento-engcom-team August 5, 2018 11:04
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2330 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop August 7, 2018 13:33
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop August 7, 2018 13:33
@magento-engcom-team magento-engcom-team merged commit f3411b6 into magento:2.3-develop Aug 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants