Skip to content

[Forwardport 2.3] allowed countries get countries for default scope #16694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Jul 10, 2018

Description

Fixed Issues (if relevant)

  1. magento/magento2#?: Not found relevant issue for the problem

Manual testing scenarios

Pre-conditions

  1. Installation with website - Website and tore - Store.
  2. Configured different 'Allowed Countries' for 'Default' and Store scopes.

Steps To Reproduce

  1. Require Magento\Directory\Model\AllowedCountries class
  2. Get Allowed Countries for default scope 0:
    Magento\Directory\Model\ResourceModel\Country::getAllowedCountries('ScopeInterface::SCOPE_STORE, 0)

Expected Result:

  1. Returned Allowed Countries for Default config

Actual Result:

  1. Will be returned Allowed Countries for default store - Store.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: Directory labels Jul 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Jul 10, 2018
@swnsma swnsma changed the title Forwardport 2.3 allowed countries get countries for default scope [Forwardport 2.3] allowed countries get countries for default scope Jul 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2377 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 579ab5e into magento:2.3-develop Aug 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Directory Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants