Skip to content

Prevent running SQL query on every item in the database when the quote is empty #16675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Prevent running SQL query on every item in the database when the quote is empty #16675

merged 1 commit into from
Jul 13, 2018

Conversation

LordZardeck
Copy link
Contributor

Description

During custom development on Magento, we needed the ability to have a quote be created and loaded into the session with no items. We started noticing performance issues throughout ajax banner loads and checkout cart loads after this change. After further inspection, we noticed that a call to \Magento\Quote\Model\ResourceModel\Quote\Item\Collection::removeItemsWithAbsentProducts resulted in a query on the catalog_product_entity table that performed a table scan across all 1.3 million products in the database, simply because no filter was being applied. The requested change simply is a check if there are any product ids to filter before attempting to filter. While this may not affect any stand-alone magento installations, it has no negative effect and if any other developer seeks to implement the capability of loading empty quotes into the session, this will alleviate potential performance issues.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @LordZardeck. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @LordZardeck. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants