Skip to content

Magento_Sales integration tests: fix invoice_list fixture var tags #16350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Magento_Sales integration tests: fix invoice_list fixture var tags #16350

merged 1 commit into from
Jun 26, 2018

Conversation

evktalo
Copy link
Contributor

@evktalo evktalo commented Jun 22, 2018

Description

In the invoice_list fixture for Magento/Sales integration tests, the var tags changed in this pull request refer to non-existing variables and the other has a wrong type.

Fixed Issues (if relevant)

None.

Manual testing scenarios

  1. Open the fixture file in PHPStorm
  2. Check if usage of the variables in the var tags can be found
  3. Check if the type of the variable is shown correctly

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @evktalo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jun 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2115 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@evktalo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@orlangur
Copy link
Contributor

Hi @evktalo! Any contributions should be applied to 2.2-develop first, please create corresponding 2.2 PRs for both of your PRs.

@magento-engcom-team
Copy link
Contributor

Hi @evktalo. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants