Skip to content

Fixed "Shop By" button disabling broken on the search page #13445 #15650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Fixed "Shop By" button disabling broken on the search page #13445 #15650

merged 1 commit into from
Aug 7, 2018

Conversation

AndreaRivadossi
Copy link
Contributor

@AndreaRivadossi AndreaRivadossi commented Jun 1, 2018

Description

Added the class "page-with-filter" in the catalogsearch_result_index.xml for fixing the issue.

Fixed Issues (if relevant)

  1. magento/magento2 #13445: "Shop By" button disabling broken on the search page

Manual testing scenarios

  1. click on the "Search" icon and search for "jacket";
  2. resize the window to a mobile size;
  3. click on "Shop By" and choose a filter with one product (e.g. "Category -> Gear");

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Added the class for fix the issue #13445
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 1, 2018

CLA assistant check
All committers have signed the CLA.

@AndreaRivadossi AndreaRivadossi changed the title Fix #13445 Fixed "Shop By" button disabling broken on the search page #13445 Jun 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 2, 2018
@magento-engcom-team
Copy link
Contributor

@AndreaRivadossi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@AndreaRivadossi
Copy link
Contributor Author

@magento-engcom-team invitation accepted. Do I have to do anything else for this task?

@magento-engcom-team
Copy link
Contributor

Hi @AndreaRivadossi. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants