Skip to content

Remove usage of $.browser as it's unused and deprecated in jQuery. Fixes #14267 #14270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jonathanKingston
Copy link
Contributor

Description

Removed all usages of $.browser as the code appears to be old or unused.

Hashchange is now supported in IE9+ so there is no need for that library also.

As mentioned in #14173 (comment) swagger will likely be updated and made to be more modular so I ignored the file:

  • app/code/Magento/Swagger/view/frontend/web/swagger-ui/js/lib/jquery.ba-bbq.min.js:

Fixed Issues (if relevant)

  1. Migration of jQuery
  2. Use of deprecated $.browser #14267

Manual testing scenarios

  1. Ensure that step-navigator.js works as expected in IE/Firefox.
  2. Ensure popup-window.js looks correct in IE.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@jonathanKingston jonathanKingston force-pushed the 2.3-develop_remove-jquery-browser branch from faa8311 to ba92086 Compare March 22, 2018 21:31
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is ok. But travis build is failed. Please fix the code style. By our convention, we should use single quote mark.
window.addEventListener("hashchange", _.bind(stepNavigator.handleHash, stepNavigator));

@jonathanKingston jonathanKingston force-pushed the 2.3-develop_remove-jquery-browser branch from ba92086 to 6c46def Compare March 23, 2018 10:48
@jonathanKingston
Copy link
Contributor Author

@VladimirZaets sorry I did see this and fixed it, however forgot to push 🤦‍♂️ Thanks for reviewing, I have pushed this now.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1039 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 6c46def into magento:2.3-develop Mar 23, 2018
@jonathanKingston jonathanKingston deleted the 2.3-develop_remove-jquery-browser branch March 24, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants