issue #13497 - Method getUrl in Magento\Catalog\Model\Product\Attribu… #13498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
orlangur
requested changes
Feb 5, 2018
| ->getBaseUrl(\Magento\Framework\UrlInterface::URL_TYPE_MEDIA) | ||
| . 'catalog/product/' . $image; | ||
| ->getBaseUrl(UrlInterface::URL_TYPE_MEDIA) | ||
| . 'catalog/product' . $image; |
There was a problem hiding this comment.
As $image may come from various sources there is no guarantee it contains leading slash.
Please
- change logic to
. 'catalog/product/' . ltrim($image, '/')instead - create a separate test case to assure there is no slash duplication
- as always, do an amend commit and force push
There was a problem hiding this comment.
@igortregub changes look good now, please squash changes into single commit and force push.
ihor-sviziev
approved these changes
Feb 5, 2018
ihor-sviziev
added
Progress: accept
Release Line: 2.2
and removed
Progress: needs update
labels
…te\Frontend returns image url with double slash
|
@igortregub thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
orlangur
approved these changes
Feb 6, 2018
thomasdom
pushed a commit
to thomasdom/magento2
that referenced
this pull request
Feb 7, 2018
Accepted Public Pull Requests: - magento#13498: issue magento#13497 - Method getUrl in Magento\Catalog\Model\Product\Attribu� (by @igortregub) - magento#13494: Fixing of Problem with updating stock item qty and stock status (by @nuzil) - magento#13132: Update the Emogrifier dependency to ^2.0.0 (by @oliverklee) Fixed store view switcher issues when changing store view on product and category pages.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preconditions
Steps to reproduce
Fixed Issues
Expected result
Actual result