Display a more meaningful error message in case of misspelt module name #12843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[LogicException] Component 'VendorA_ModuleB' of type '' is not correctly registered. instead of [Magento\Framework\Exception\FileSystemException] The file "/composer.json" doesn't exist
|
Jānis Elmeris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
ihor-sviziev
requested changes
Dec 22, 2017
| @@ -45,6 +45,10 @@ public function getDir($moduleName, $type = '') | |||
| { | |||
| $path = $this->componentRegistrar->getPath(ComponentRegistrar::MODULE, $moduleName); | |||
|
|
|||
| if (! isset($path)) { | |||
There was a problem hiding this comment.
Please remove space before isset function, it's not needed there
| @@ -45,6 +45,10 @@ public function getDir($moduleName, $type = '') | |||
| { | |||
| $path = $this->componentRegistrar->getPath(ComponentRegistrar::MODULE, $moduleName); | |||
|
|
|||
| if (! isset($path)) { | |||
| throw new \LogicException("Component '$moduleName' of type '$type' is not correctly registered."); | |||
There was a problem hiding this comment.
This change is not backward compatible, you're adding new exception type that could be thrown. I think it would be better to use \InvalidArgumentException in order to keep backward compatibility there.
ihor-sviziev
approved these changes
Feb 15, 2018
|
Hi @ihor-sviziev, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 15, 2018
…spelt module name #12843
This was referenced Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displays a more meaningful error message in case of misspelt module name.
[LogicException] Component 'VendorA_ModuleB' of type '' is not correctly registered.instead of
[Magento\Framework\Exception\FileSystemException] The file "/composer.json" doesn't existManual testing scenarios
bin/magento module:disable Magento_Bundle(orbin/magento module:enable Magento_Bundle, if it is disabled); yes, it does not have to be the same incorrectly configured module, any will do.