Skip to content

[Backport] Cron starts when it's already running #12805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Backport] Cron starts when it's already running #12805

wants to merge 1 commit into from

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Dec 19, 2017 •
edited by toddhainsworth
Loading

Description

This is a backport to 2.1-develop for the fix from 2992ee2

Fixed Issues (if relevant)

  1. Cron starts when it's already running #10650: Cron starts when it's already running

Manual testing scenarios

  1. Create a cron that takes a while (for example, sleep 15 minutes)
  2. Schedule it to run every 5 minutes
  3. The other jobs should wait for the first job to complete, even though they are scheduled to run every 5 minutes.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@cpartica @dmanners
Merge pull request magento#1227 from magento-okapis/Okapis-develop-pr
6a1a94e 
[okapis] MAGETWO-69629: Deadlock Error While indexing Category products
@magento-engcom-team magento-engcom-team added bugfix Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release SQUASHTOBERFEST labels Dec 19, 2017
@dmanners dmanners mentioned this pull request Dec 21, 2017
Closed
@fooman fooman self-assigned this Dec 30, 2017
@fooman fooman added this to the December 2017 milestone Dec 30, 2017
@okorshenko okorshenko modified the milestones: December 2017, January 2018 Jan 8, 2018
@dmanners dmanners closed this Jan 24, 2018
@dmanners dmanners deleted the backport-for-10650 branch January 24, 2018 16:42
@dmanners dmanners restored the backport-for-10650 branch January 24, 2018 16:45
@dmanners
Copy link
Contributor Author

Sorry deleted the wrong branch :(

@dmanners dmanners reopened this Jan 24, 2018
@okorshenko okorshenko modified the milestones: January 2018, February 2018 Feb 7, 2018
@hostep hostep mentioned this pull request Feb 20, 2018
Closed
@okorshenko okorshenko modified the milestones: February 2018, March 2018 Mar 1, 2018
@fooman
Copy link
Contributor

fooman commented Mar 14, 2018

Let's wait on #11002 before progressing this one.

@fooman fooman removed their assignment Mar 14, 2018
@ihor-sviziev ihor-sviziev self-assigned this Mar 23, 2018
@sidolov
Copy link
Contributor

sidolov commented Mar 28, 2018

PR with fix for 2.2-develop: #12497

@ihor-sviziev
Copy link
Contributor

Hi @dmanners, could you update your PR to include all the commits from original PR?

@dmanners
Copy link
Contributor Author

Thanks for the reminder @ihor-sviziev I will close this and use the backporting tool to create this again will all commits.

@dmanners dmanners closed this Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ihor-sviziev ihor-sviziev

Labels
bugfix Progress: needs update Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
7 participants
@dmanners @fooman @sidolov @ihor-sviziev @okorshenko @magento-engcom-team @cpartica