Skip to content

magento/magento2#12699: Multiselect Attribute is not saved #12767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2017

Conversation

andrii-dymov
Copy link

@andrii-dymov andrii-dymov commented Dec 15, 2017

Fixed attribute loading for different entities in AbstractEntity

Description

Fixed attribute loading for different entities in AbstractEntity

Fixed Issues (if relevant)

  1. magento/magento2#12699: Multiselect Attribute is not saved #12767: Multiselect Attribute is not saved for a product in the admin panel when it has a related product using another attribute set

Manual testing scenarios

Steps to reproduce

Create 2 attribute sets from the Default one.
Create a multi-select attribute and assign it to set #1.
Create a product 1 with attribute set #2.
Create a product 2 with attribute set #1 and set a product 1 as it's related product.
Save product 2 without populating the multi-select.
Edit the product 2, populate multi-select and click save.
Notice the selected option is not saved
Expected result

Multiselect Attribute should be saved for a product in the admin panel when it has a related product using another attribute set.

Actual result

Multiselect Attribute is not saved for a product in the admin panel when it has a related product using another attribute set

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 15, 2017

CLA assistant check
All committers have signed the CLA.

@sidolov sidolov self-assigned this Dec 18, 2017
@sidolov sidolov added this to the December 2017 milestone Dec 18, 2017
*
* @var array
*/
protected $attributesByScope = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute should be private

@sidolov
Copy link
Contributor

sidolov commented Dec 19, 2017

Refactored according to backward compatible development requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants