Skip to content

Update CAPTCHA labels to reflect the symbols in the CAPTCHA image #12387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Update CAPTCHA labels to reflect the symbols in the CAPTCHA image #12387

merged 1 commit into from
Nov 22, 2017

Conversation

RhodriOwainDavies
Copy link

@RhodriOwainDavies RhodriOwainDavies commented Nov 22, 2017

Description

The text labels referring to the CAPTCHA image only refer to letters, when there are also numbers in the CAPTCHA images. Meaning the instruction to the user is ambiguous. The message implies to NOT enter the numbers, thus the CAPTCHA doesn't match.

I've changed the labels in a few places and updated the dictionary file

Manual testing scenarios

  1. As a customer visit the sign-in page and enter the wrong password for the same email address several times until the captcha image & label appears
  2. As a merchant visit the admin login page and enter the wrong password for the same user account several times until the captcha image & label appears
  3. Install a language pack which includes a dictionary key for the new phrases, change the language of the store and repeat steps 1 & 2 ensuring the phrases appear in their translated forms.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants