Trying to get data from non existent products #12321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling Products in Cart report, it called data of deleted products resulting in exception trying to access $productData[$item->getProductId()]
|
Thank you @angelo983 for your PR. Could you please add some manual test cases and mention any related issue. See our guidelines for more information https://github.com/magento/magento2/blob/2.2-develop/PULL_REQUEST_TEMPLATE.md |
- Fixed according to static test results
|
Hi @angelo983 |
|
@ishakhsuvarov have I to open new pull requests to provide a similar fix for 2.2-develop and possibly 2.3-develop? |
|
@angelo983 That would be really helpful |
This was referenced Dec 4, 2017
|
Now I have applied the same fix for 2.2-develop and 2.3-develop but I had to open other two pull requests. |
|
@angelo983 Thank you |
magento-team
pushed a commit
that referenced
this pull request
Dec 6, 2017
magento-team
pushed a commit
that referenced
this pull request
Dec 6, 2017
[EngCom] Public Pull Requests - 2.1-develop - MAGETWO-84476: Trying to get data from non existent products #12321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling Products in Cart report, it called data of deleted products resulting in exception trying to access $productData[$item->getProductId()]
Preconditions
Steps to reproduce
Expected result
Actual result