Skip to content

FR#10231_22 Custom URL Rewrite Not working [backport 2.2] #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

mrodespin
Copy link
Contributor

@mrodespin mrodespin commented Oct 15, 2017

Magento custom url rewrites functionality is not working when adding a redirection of magento controllers. For example a custom redirection from /customer/account/create to another page.

Description

This commit modifies the order that magento loads the routerList pushing urlrewrite router before magento base router. Thats the same order that Magento 1 uses in the function dispatch() on web/app/code/core/Mage/Core/Controller/Varien/Front.php controller.

Related PRs:

#11469
#11471

Fixed Issues (if relevant)

  1. Custom URL Rewrite Not working #10231: Custom URL Rewrite Not working

Manual testing scenarios

  1. Add New Custom URL Rewrite
  2. Set Request Path customer/account/create and Target Path customer/account/login
  3. It should redirect customer/account/create page To customer/account/login page same like Magento 1.x

When adding this modification the expected result is accomplish

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mrodespin
Copy link
Contributor Author

@okorshenko can you add the partner contribution label?

@vrann
Copy link
Contributor

vrann commented Oct 19, 2017

@mrodespin in order to track your PR against partner contribution, you must accept an invite to the magento-partner organization. Please check your emails from the github, it should contain a link. Label is just for visibility

@mrodespin
Copy link
Contributor Author

@vrann i just accepted the invitation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants