Skip to content

[Backport 2.1] Append shipment comment to shipment if appendComment is true #11386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Oct 11, 2017

Description

Add customer note to shipment if shipment is created with API and "appendComment" is set to true.

Fixed Issues (if relevant)

  1. Shipment API won't append comment to email #11207: Shipment API won't append comment to email

Manual testing scenarios

  1. Place an order via the website.
  2. Create a shipment using the API with "appendComment": true.
  3. Add comment to the shipment in same request.
  4. Shipment email is being send with comment appended.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vrann vrann self-assigned this Oct 12, 2017
@vrann vrann added this to the October 2017 milestone Oct 12, 2017
@JeroenVanLeusden JeroenVanLeusden changed the title [Backport] Append shipment comment to shipment if appendComment is true [Backport 2.1] Append shipment comment to shipment if appendComment is true Oct 16, 2017
@magento-team magento-team merged commit f38f326 into magento:2.1-develop Oct 19, 2017
magento-team pushed a commit that referenced this pull request Oct 19, 2017
@JeroenVanLeusden JeroenVanLeusden deleted the patch-2 branch December 4, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants